-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 1.1.1 issue template and input manifests #1275
Add 1.1.1 issue template and input manifests #1275
Conversation
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
…ch runs Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
…o opensearch-release-1.1.1
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
…ch runs Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #1275 +/- ##
============================================
+ Coverage 94.08% 94.15% +0.06%
Complexity 11 11
============================================
Files 127 132 +5
Lines 2875 2924 +49
Branches 10 10
============================================
+ Hits 2705 2753 +48
- Misses 160 161 +1
Partials 10 10
Continue to review full report at Codecov.
|
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
…o opensearch-release-1.1.1
@@ -18,7 +18,9 @@ def __init__(self, component, url): | |||
|
|||
def check(self): | |||
for architecture in BuildArgs.SUPPORTED_ARCHITECTURES: | |||
url = "/".join([self.component.dist, architecture, "manifest.yml"]) | |||
# Since we only have 'linux' builds now we hard code it to 'linux' | |||
# Once we have all platform builds we can adding a second loop for 'BuildArgs.SUPPORTED_PLATFORMS' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can it be self.target.platform
instead of hard-coded linux
, and then the comment is moot?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This target
is CiTarget
, which does not have the platform
var.
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume we are going to cut the 1.1.1 components issues as soon as this is merged - so I request that the first pre-release
instruction is changed per that comment thread, all other feedback is at your discretion.
.github/meta_issue_template/release-1.1.1-component-issues-min.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Description
Add 1.1.1 issue template and input manifests.
This is an improvement of the now closed #1100.
Issues Resolved
Related to #870
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.