Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1.1.1 issue template and input manifests #1275

Merged

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented Dec 8, 2021

Description

Add 1.1.1 issue template and input manifests.
This is an improvement of the now closed #1100.

Issues Resolved

Related to #870

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
…ch runs

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
…ch runs

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2021

Codecov Report

Merging #1275 (92b285e) into main (bbcb018) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1275      +/-   ##
============================================
+ Coverage     94.08%   94.15%   +0.06%     
  Complexity       11       11              
============================================
  Files           127      132       +5     
  Lines          2875     2924      +49     
  Branches         10       10              
============================================
+ Hits           2705     2753      +48     
- Misses          160      161       +1     
  Partials         10       10              
Impacted Files Coverage Δ
src/ci_workflow/ci_check_manifest_component.py 100.00% <100.00%> (ø)
src/ci_workflow/ci_input_manifest.py 100.00% <100.00%> (ø)
src/ci_workflow/ci_target.py 100.00% <100.00%> (ø)
src/test_workflow/test_args.py 100.00% <0.00%> (ø)
src/checkout_workflow/checkout_args.py 100.00% <0.00%> (ø)
src/assemble_workflow/bundle_recorder.py 100.00% <0.00%> (ø)
...orkflow/integ_test/integ_test_runner_opensearch.py 100.00% <0.00%> (ø)
...eg_test/integ_test_runner_opensearch_dashboards.py 100.00% <0.00%> (ø)
src/assemble_workflow/bundle_locations.py 100.00% <0.00%> (ø)
src/test_workflow/test_kwargs.py 100.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbcb018...92b285e. Read the comment docs.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
src/ci_workflow/ci_input_manifest.py Outdated Show resolved Hide resolved
@@ -18,7 +18,9 @@ def __init__(self, component, url):

def check(self):
for architecture in BuildArgs.SUPPORTED_ARCHITECTURES:
url = "/".join([self.component.dist, architecture, "manifest.yml"])
# Since we only have 'linux' builds now we hard code it to 'linux'
# Once we have all platform builds we can adding a second loop for 'BuildArgs.SUPPORTED_PLATFORMS'
Copy link
Member

@dblock dblock Dec 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can it be self.target.platform instead of hard-coded linux, and then the comment is moot?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This target is CiTarget, which does not have the platform var.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume we are going to cut the 1.1.1 components issues as soon as this is merged - so I request that the first pre-release instruction is changed per that comment thread, all other feedback is at your discretion.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon peterzhuamazon merged commit 760b5f2 into opensearch-project:main Dec 9, 2021
@peterzhuamazon peterzhuamazon deleted the opensearch-release-1.1.1 branch December 9, 2021 17:27
@peterzhuamazon peterzhuamazon mentioned this pull request Dec 9, 2021
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants