Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename min bundle folder name in patch releases. #1287

Merged
merged 1 commit into from
Dec 10, 2021

Conversation

dblock
Copy link
Member

@dblock dblock commented Dec 10, 2021

Signed-off-by: dblock dblock@dblock.org

Description

We extract the min bundle and figure out the folder name that it created (e.g. openseach-1.1.0). In this change we rename that folder to the distribution version being built, if necessary, e.g. opensearch-1.1.1.

The changes to the test .zip and .tar.gz rename a folder called "bundle" to what they are in real life bundles, "opensearch-1.0.0" or "opensearch-dashboards-1.1.0".

Issues Resolved

Closes #1286.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: dblock <dblock@dblock.org>
@dblock dblock requested review from peternied, peterzhuamazon and a team December 10, 2021 15:46
@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2021

Codecov Report

Merging #1287 (ac07cd9) into main (90ad75b) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1287      +/-   ##
============================================
+ Coverage     94.18%   94.20%   +0.02%     
  Complexity       11       11              
============================================
  Files           133      133              
  Lines          2921     2935      +14     
  Branches          8        8              
============================================
+ Hits           2751     2765      +14     
  Misses          162      162              
  Partials          8        8              
Impacted Files Coverage Δ
src/assemble_workflow/bundle.py 94.59% <100.00%> (+0.07%) ⬆️
src/assemble_workflow/dist.py 95.65% <100.00%> (+1.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90ad75b...ac07cd9. Read the comment docs.

Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@peterzhuamazon peterzhuamazon merged commit fa6d482 into opensearch-project:main Dec 10, 2021
@peterzhuamazon peterzhuamazon mentioned this pull request Dec 10, 2021
30 tasks
@dblock dblock deleted the fix-min-bundle-name branch December 10, 2021 17:23
@tianleh
Copy link
Member

tianleh commented Dec 11, 2021

This change breaks the Dashboards integ test since it is following the old convention to look for opensearch-dashboards-1.2.0-linux-x64 which is now opensearch-dashboards-1.2.0
https://github.com/opensearch-project/opensearch-build/blob/main/src/test_workflow/integ_test/service_opensearch_dashboards.py#L35

I will work on a corresponding change. @dblock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]Patch bundle tar has min version number
5 participants