Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SQL until it bumps log4j 2.17.1. #1419

Merged
merged 1 commit into from
Dec 30, 2021

Conversation

dblock
Copy link
Member

@dblock dblock commented Dec 30, 2021

Signed-off-by: dblock dblock@amazon.com

Description

opensearch-project/sql#354 is failing because there's no snapshot build, and there's no snapshot build because sql is included in it; remove it for now

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: dblock <dblock@amazon.com>
@dblock dblock requested a review from a team as a code owner December 30, 2021 14:51
@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2021

Codecov Report

Merging #1419 (baf1148) into main (80b3fb4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1419   +/-   ##
=========================================
  Coverage     94.13%   94.13%           
  Complexity       11       11           
=========================================
  Files           139      139           
  Lines          3086     3086           
  Branches          8        8           
=========================================
  Hits           2905     2905           
  Misses          173      173           
  Partials          8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80b3fb4...baf1148. Read the comment docs.

@dblock dblock enabled auto-merge (squash) December 30, 2021 16:59
@dblock dblock merged commit a7a7e96 into opensearch-project:main Dec 30, 2021
dblock added a commit that referenced this pull request Dec 31, 2021
dblock added a commit to dblock/opensearch-build that referenced this pull request Dec 31, 2021
)"

This reverts commit a7a7e96.

Signed-off-by: dblock <dblock@dblock.org>
dblock added a commit that referenced this pull request Jan 3, 2022
This reverts commit a7a7e96.

Signed-off-by: dblock <dblock@dblock.org>
@dblock dblock deleted the remove-sql-log4j-2.17.1 branch March 11, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants