Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jenkins CI for CCR Performance tests #2005

Merged
merged 3 commits into from
Apr 22, 2022

Conversation

ankitkala
Copy link
Member

@ankitkala ankitkala commented Apr 20, 2022

Signed-off-by: Ankit Kala ankikala@amazon.com

Description

  • Adds the JenkinsFile for triggering CCR Performance tests.
  • Add support for creating multi node clusters via PerfTestCluster

Issues Resolved

1500

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ankitkala ankitkala requested a review from a team as a code owner April 20, 2022 17:54
@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2022

Codecov Report

Merging #2005 (5424daf) into main (8e850c0) will increase coverage by 0.21%.
The diff coverage is 93.24%.

@@             Coverage Diff              @@
##               main    #2005      +/-   ##
============================================
+ Coverage     94.28%   94.50%   +0.21%     
============================================
  Files           184      152      -32     
  Lines          3747     3730      -17     
  Branches         29       19      -10     
============================================
- Hits           3533     3525       -8     
+ Misses          208      205       -3     
+ Partials          6        0       -6     
Impacted Files Coverage Δ
src/test_workflow/perf_test/perf_test_cluster.py 80.00% <76.19%> (-2.86%) ⬇️
...test_workflow/perf_test/perf_multi_node_cluster.py 100.00% <100.00%> (ø)
...est_workflow/perf_test/perf_single_node_cluster.py 100.00% <100.00%> (ø)
...est_workflow/perf_test/perf_test_cluster_config.py 100.00% <100.00%> (ø)
..._workflow/perf_test/perf_test_runner_opensearch.py 96.77% <100.00%> (+0.10%) ⬆️
...w/perf_test/perf_test_runner_opensearch_plugins.py 100.00% <100.00%> (+4.34%) ⬆️
src/system/temporary_directory.py 83.87% <0.00%> (-12.91%) ⬇️
src/system/os.py 93.75% <0.00%> (-6.25%) ⬇️
...rkflow/integ_test/service_opensearch_dashboards.py 96.00% <0.00%> (-2.22%) ⬇️
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e850c0...5424daf. Read the comment docs.

Signed-off-by: Ankit Kala <ankikala@amazon.com>
Signed-off-by: Ankit Kala <ankikala@amazon.com>
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a lot better.

I have some smaller asks that you might want to consider before merging.

Also fix CI.

@ankitkala
Copy link
Member Author

This is a lot better.

I have some smaller asks that you might want to consider before merging.

Also fix CI.

Addressed all the comments and fixed the broken tests.

Copy link
Member

@gaiksaya gaiksaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are some failing tests for windows.

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is still failing + some more small stuff

src/test_workflow/perf_test/perf_multi_node_cluster.py Outdated Show resolved Hide resolved
src/test_workflow/perf_test/perf_single_node_cluster.py Outdated Show resolved Hide resolved
src/test_workflow/perf_test/perf_multi_node_cluster.py Outdated Show resolved Hide resolved
@ankitkala ankitkala force-pushed the jenkins-pr branch 2 times, most recently from 3d61902 to 5424daf Compare April 22, 2022 18:14
@ankitkala ankitkala force-pushed the jenkins-pr branch 7 times, most recently from 5631bec to c114c06 Compare April 22, 2022 19:32
Signed-off-by: Ankit Kala <ankikala@amazon.com>
@dblock dblock merged commit 508768b into opensearch-project:main Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants