Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing always block inside post #2029

Merged
merged 2 commits into from
Apr 22, 2022

Conversation

tianleh
Copy link
Member

@tianleh tianleh commented Apr 22, 2022

Signed-off-by: Tianle Huang tianleh@amazon.com

Description

During testing of the Jenkins job, I find this following error.

Started by user [opensearch](http://jenki-jenki-fpgmrv2ryxko-1366042710.us-east-1.elb.amazonaws.com/user/admin)
Rebuilds build #[17](http://jenki-jenki-fpgmrv2ryxko-1366042710.us-east-1.elb.amazonaws.com/job/Playground/job/tianleh-test/job/tianleh-os-yum-4-12/17)
Obtained jenkins/opensearch/distribution-build.jenkinsfile from git https://github.com/tianleh/opensearch-build.git
Running in Durability level: MAX_SURVIVABILITY
org.codehaus.groovy.control.MultipleCompilationErrorsException: startup failed:
WorkflowScript: 397: Expected a symbol @ line 397, column 29.
                               lib.jenkins.Messages.new(this).add(
                               ^

WorkflowScript: 396: Invalid condition "script" - valid conditions are [always, changed, fixed, regression, aborted, success, unsuccessful, unstable, failure, notBuilt, cleanup] @ line 396, column 25.
                           script {
                           ^

WorkflowScript: 397: Arguments to "error" must be explicitly named. @ line 397, column 29.
                               lib.jenkins.Messages.new(this).add(
                               ^

3 errors

	at org.codehaus.groovy.control.ErrorCollector.failIfErrors(ErrorCollector.java:310)
	at org.codehaus.groovy.control.CompilationUnit.applyToPrimaryClassNodes(CompilationUnit.java:1085)
	at org.codehaus.groovy.control.CompilationUnit.doPhaseOperation(CompilationUnit.java:603)
	at org.codehaus.groovy.control.CompilationUnit.processPhaseOperations(CompilationUnit.java:581)
	at org.codehaus.groovy.control.CompilationUnit.compile(CompilationUnit.java:558)
	at groovy.lang.GroovyClassLoader.doParseClass(GroovyClassLoader.java:298)
	at groovy.lang.GroovyClassLoader.parseClass(GroovyClassLoader.java:268)
	at groovy.lang.GroovyShell.parseClass(GroovyShell.java:688)
	at groovy.lang.GroovyShell.parse(GroovyShell.java:700)
	at org.jenkinsci.plugins.workflow.cps.CpsGroovyShell.doParse(CpsGroovyShell.java:142)
	at org.jenkinsci.plugins.workflow.cps.CpsGroovyShell.reparse(CpsGroovyShell.java:127)
	at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution.parseScript(CpsFlowExecution.java:571)
	at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution.start(CpsFlowExecution.java:523)
	at org.jenkinsci.plugins.workflow.job.WorkflowRun.run(WorkflowRun.java:337)
	at hudson.model.ResourceController.execute(ResourceController.java:97)
	at hudson.model.Executor.run(Executor.java:429)
Finished: FAILURE

Issues Resolved

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Tianle Huang <tianleh@amazon.com>
@tianleh tianleh requested a review from a team as a code owner April 22, 2022 19:40
Signed-off-by: Tianle Huang <tianleh@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2022

Codecov Report

Merging #2029 (60cf5a8) into main (7012178) will increase coverage by 0.06%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2029      +/-   ##
============================================
+ Coverage     94.17%   94.23%   +0.06%     
  Complexity       25       25              
============================================
  Files           195      198       +3     
  Lines          3860     3902      +42     
  Branches         29       29              
============================================
+ Hits           3635     3677      +42     
  Misses          219      219              
  Partials          6        6              
Impacted Files Coverage Δ
src/test_workflow/perf_test/perf_test_cluster.py 80.00% <0.00%> (-2.86%) ⬇️
...est_workflow/perf_test/perf_single_node_cluster.py 100.00% <0.00%> (ø)
...est_workflow/perf_test/perf_test_cluster_config.py 100.00% <0.00%> (ø)
...test_workflow/perf_test/perf_multi_node_cluster.py 100.00% <0.00%> (ø)
..._workflow/perf_test/perf_test_runner_opensearch.py 96.77% <0.00%> (+0.10%) ⬆️
...w/perf_test/perf_test_runner_opensearch_plugins.py 100.00% <0.00%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7012178...60cf5a8. Read the comment docs.

@tianleh tianleh merged commit b9f83df into opensearch-project:main Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants