Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back binding to 0.0.0.0 for the OSD docker images #2036

Conversation

peterzhuamazon
Copy link
Member

Signed-off-by: Peter Zhu zhujiaxi@dev-dsk-zhujiaxi-2a-c8d595b4.us-west-2.amazon.com

Description

Add back binding to 0.0.0.0 for the OSD docker images

Issues Resolved

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Zhu <zhujiaxi@dev-dsk-zhujiaxi-2a-c8d595b4.us-west-2.amazon.com>
@peterzhuamazon peterzhuamazon self-assigned this Apr 26, 2022
@peterzhuamazon peterzhuamazon requested a review from a team as a code owner April 26, 2022 00:36
@codecov-commenter
Copy link

Codecov Report

Merging #2036 (757e197) into main (b9f83df) will increase coverage by 5.76%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main     #2036      +/-   ##
=============================================
+ Coverage     94.23%   100.00%   +5.76%     
=============================================
  Files           198         6     -192     
  Lines          3902       105    -3797     
  Branches         29        19      -10     
=============================================
- Hits           3677       105    -3572     
+ Misses          219         0     -219     
+ Partials          6         0       -6     
Impacted Files Coverage Δ
src/manifests_workflow/input_manifests.py
tests/jenkins/jobs/BuildYumRepo_Jenkinsfile
...enkins/jobs/BuildDockerImage_Qualifier_Jenkinsfile
tests/jenkins/jobs/Messages_Jenkinsfile
src/manifests/bundle_manifest.py
src/system/config_file.py
src/manifests/distribution.py
tests/jenkins/jobs/GetManifestSHA_Jenkinsfile
...ts_workflow/component_opensearch_dashboards_min.py
src/system/os.py
... and 182 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b439dcb...757e197. Read the comment docs.

@peterzhuamazon peterzhuamazon merged commit ff32ce7 into opensearch-project:main Apr 26, 2022
@peterzhuamazon peterzhuamazon deleted the opensearch-2.0.0-dashboards-docker branch April 26, 2022 00:44
@kavilla
Copy link
Member

kavilla commented Apr 26, 2022

LGTM I don't remember explicitly setting this value for OpenSearch Dashboards with security but do without security. But just checked and it works for both.

@peterzhuamazon
Copy link
Member Author

LGTM I don't remember explicitly setting this value for OpenSearch Dashboards with security but do without security. But just checked and it works for both.

The binding is always there but in a recent commit it is accidentally removed after the cleanup.

We maintain 2 copies of the yml file previous, and I combine them in #1985 and somehow missed the setting.
Thanks.

@peterzhuamazon peterzhuamazon restored the opensearch-2.0.0-dashboards-docker branch May 2, 2022 22:07
@peterzhuamazon peterzhuamazon deleted the opensearch-2.0.0-dashboards-docker branch May 2, 2022 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docker release v2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants