-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak promotion pipeline to support rpm and qualifier #2094
Tweak promotion pipeline to support rpm and qualifier #2094
Conversation
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #2094 +/- ##
=========================================
Coverage 94.23% 94.23%
Complexity 25 25
=========================================
Files 198 202 +4
Lines 3902 3906 +4
Branches 29 29
=========================================
+ Hits 3677 3681 +4
Misses 219 219
Partials 6 6
Continue to review full report at Codecov.
|
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Note: If that PR get merged this PR needs some changes. Thanks. |
…nSearch#3193 Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
c9474d9
to
01ecd47
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one ask for the function name change, otherwise looks good!
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
…azon/opensearch-build into opensearch-promotion-workflow
…o opensearch-promotion-workflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved to unblock, but the fact that we have to do distribution_local.equals('tar'))
in promoteArtifacts
should be refactored into something better.
Signed-off-by: Peter Zhu zhujiaxi@amazon.com
Description
Tweak promotion pipeline to support rpm and qualifier
Issues Resolved
Part of #2076
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.