Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak promotion pipeline to support rpm and qualifier #2094

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented May 5, 2022

Signed-off-by: Peter Zhu zhujiaxi@amazon.com

Description

Tweak promotion pipeline to support rpm and qualifier

Issues Resolved

Part of #2076

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon peterzhuamazon requested review from bbarani and zelinh May 5, 2022 21:54
@peterzhuamazon peterzhuamazon requested a review from a team as a code owner May 5, 2022 21:54
@peterzhuamazon peterzhuamazon self-assigned this May 5, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 5, 2022

Codecov Report

Merging #2094 (f527394) into main (5dfa913) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main    #2094   +/-   ##
=========================================
  Coverage     94.23%   94.23%           
  Complexity       25       25           
=========================================
  Files           198      202    +4     
  Lines          3902     3906    +4     
  Branches         29       29           
=========================================
+ Hits           3677     3681    +4     
  Misses          219      219           
  Partials          6        6           
Impacted Files Coverage Δ
...PromoteArtifacts_OpenSearch_Dashboards_Jenkinsfile 100.00% <ø> (ø)
...rtifacts_actions_OpenSearch_Dashboards_Jenkinsfile 100.00% <ø> (ø)
src/sign_workflow/signer.py 97.61% <100.00%> (ø)
...jenkins/jobs/PromoteArtifactsQualifier_Jenkinsfile 100.00% <100.00%> (ø)
...tifactsQualifier_OpenSearch_Dashboards_Jenkinsfile 100.00% <100.00%> (ø)
...jobs/PromoteArtifactsQualifier_actions_Jenkinsfile 100.00% <100.00%> (ø)
...ualifier_actions_OpenSearch_Dashboards_Jenkinsfile 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5dfa913...f527394. Read the comment docs.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon peterzhuamazon requested a review from tianleh May 5, 2022 22:58
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon
Copy link
Member Author

Note:
@saratvemulapalli has issued a fix to the core-plugin wrong folder: opensearch-project/OpenSearch#3193.

If that PR get merged this PR needs some changes.

Thanks.

@peterzhuamazon peterzhuamazon force-pushed the opensearch-promotion-workflow branch from c9474d9 to 01ecd47 Compare May 6, 2022 00:33
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one ask for the function name change, otherwise looks good!

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
…azon/opensearch-build into opensearch-promotion-workflow
@peterzhuamazon peterzhuamazon requested a review from dblock May 10, 2022 22:07
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved to unblock, but the fact that we have to do distribution_local.equals('tar')) in promoteArtifacts should be refactored into something better.

@peterzhuamazon peterzhuamazon merged commit f318149 into opensearch-project:main May 11, 2022
@peterzhuamazon peterzhuamazon deleted the opensearch-promotion-workflow branch May 11, 2022 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Add support for promotion workflow for qualifier and rpm
3 participants