Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Notes tracker for component repos #2400

Closed

Conversation

prudhvigodithi
Copy link
Member

@prudhvigodithi prudhvigodithi commented Aug 2, 2022

Description

  • Release tracker for component repos, thats gives information about the most recent commitID after a specific date and checks if there are any associated release notes.
    Expected inputs:
  1. GIT_LOG_DATE: To check if commit exists after a specific date
  2. ADD_COMMENT: true/false
  3. GIT_ISSUE_NUMBER: release issue to add the generated tabel as comment.
  4. GITHUB_TOKEN: token used to add the comment
  • This PR adds code that adheres to existing workflows

  • Execution command: ./run_releasenotes_check.sh manifests/2.2.0/opensearch-2.2.0.yml

  • Create a mark-down table as follows, adding the latest commitID after a certain date, and if contains a release notes with YES/NO/NULL

|    Repo    |Branch|CommitID|Release Notes|
|------------|------|--------|-------------|
|OpenSearch  |2.x   |        |NO           |
|common-utils|2.x   |        |NO           |
|security    |main  |        |YES          |
  • Pending: To update README

Issues Resolved

#2345

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2022

Codecov Report

Merging #2400 (b659bbe) into main (abfca2d) will decrease coverage by 0.41%.
The diff coverage is 69.01%.

@@             Coverage Diff              @@
##               main    #2400      +/-   ##
============================================
- Coverage     94.62%   94.21%   -0.42%     
  Complexity       27       27              
============================================
  Files           210      211       +1     
  Lines          4317     4388      +71     
  Branches         29       29              
============================================
+ Hits           4085     4134      +49     
- Misses          226      248      +22     
  Partials          6        6              
Impacted Files Coverage Δ
src/run_releasenotes_check.py 69.01% <69.01%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@prudhvigodithi prudhvigodithi marked this pull request as ready for review August 3, 2022 01:26
@prudhvigodithi prudhvigodithi requested a review from a team as a code owner August 3, 2022 01:26
@prudhvigodithi prudhvigodithi changed the title Release tracker for component repos Release Notes tracker for component repos Aug 3, 2022
Pipfile Outdated Show resolved Hide resolved
Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also create a folder to host this .py file, instead of putting it in src dir.

@prudhvigodithi
Copy link
Member Author

prudhvigodithi commented Aug 4, 2022

Please also create a folder to host this .py file, instead of putting it in src dir.

With existing setup when I create a sub-folder src/releasenotes_check_workflow and host the python code run_releasenotes_check.py , calling from "$DIR/run.sh" "$DIR/src/releasenotes_check_workflow/run_releasenotes_check.py" $@
modules fail to load @peterzhuamazon

Installing dependencies from Pipfile.lock (d8d8d9)...
  🐍   ▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉ 0/0 — 00:00:00
To activate this project's virtualenv, run pipenv shell.
Alternatively, run a command inside the virtualenv with pipenv run.
Running ./src/releasenotes_check_workflow/run_releasenotes_check.py manifests/2.2.0/opensearch-2.2.0.yml ...
Traceback (most recent call last):
  File "./src/releasenotes_check_workflow/run_releasenotes_check.py", line 8, in <module>
    from checkout_workflow.checkout_args import CheckoutArgs```

@prudhvigodithi prudhvigodithi force-pushed the release-check branch 2 times, most recently from a01b8d2 to cfb3960 Compare August 8, 2022 11:22
Signed-off-by: prudhvigodithi <pgodithi@amazon.com>
@prudhvigodithi
Copy link
Member Author

Closing this PR in favor of #2438

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants