Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pickup Java version from .properties in OpenSearch gradle check #2462

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

reta
Copy link
Contributor

@reta reta commented Aug 16, 2022

Signed-off-by: Andriy Redko andriy.redko@aiven.io

Description

Pickup Java version from .properties in OpenSearch gradle check

Issues Resolved

Closes opensearch-project/OpenSearch#2395

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta reta requested a review from a team as a code owner August 16, 2022 14:48
@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2022

Codecov Report

Merging #2462 (34a9150) into main (0720e05) will decrease coverage by 0.13%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2462      +/-   ##
============================================
- Coverage     94.63%   94.50%   -0.14%     
  Complexity       27       27              
============================================
  Files           213      207       -6     
  Lines          4324     4219     -105     
  Branches         29       10      -19     
============================================
- Hits           4092     3987     -105     
  Misses          226      226              
  Partials          6        6              
Impacted Files Coverage Δ
...loyment/lambdas/cf-url-rewriter/cf-url-rewriter.ts
deployment/lib/identities.ts
deployment/lambdas/cf-url-rewriter/https-get.ts
deployment/lib/buckets.ts
deployment/lib/build-artifact-stack.ts
deployment/lib/artifacts-public-access.ts

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 just need to fix tests

@reta
Copy link
Contributor Author

reta commented Aug 16, 2022

clap just need to fix tests

On it!

@reta reta force-pushed the issue-2395 branch 2 times, most recently from 521a092 to 227c3c1 Compare August 16, 2022 16:44
@dblock
Copy link
Member

dblock commented Aug 16, 2022

https://github.com/opensearch-project/opensearch-build/blob/main/DEVELOPER_GUIDE.md#regression-tests wink wink

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@dblock dblock merged commit 85668d6 into opensearch-project:main Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pickup Java version from .properties in OpenSearch gradle check
3 participants