Build index-management that requires artifacts from previous components. #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peternied
approved these changes
Aug 18, 2021
I know :( |
…ent. Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: dblock <dblock@amazon.com>
dblock
force-pushed
the
build-artifacts
branch
from
6dd9998
to
d473b8a
Compare
dblock
changed the title
mch2
reviewed
Aug 18, 2021
| echo "error: missing $ZIP, $plugin must be built first" | ||
| exit 1 | ||
| fi | ||
| cp $ZIP src/test/resources/$plugin |
There was a problem hiding this comment.
Is this only required for a test gradle task? In our build here we are skipping tests and relying on test steps to be run on merge/pr and later after a bundle is assembled during the test workflow.
There was a problem hiding this comment.
Yes. I suppose I should spend a bit more time trying to figure out how to disable that before introducing a whole feature :)
|
Both these projects decided to continue checking in the .zips, and this was needed to run integration tests only, so we don't need this. opensearch-project/index-management#121 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: dblock dblock@amazon.com
Description
Adds the capability for a script to consume previously built components. This is needed for index-management that needs a job-scheduler and notifications plugin to build.
If you know a way to disable certain tests in that one to avoid needing these, I'd probably prefer that.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.