Upload test results based on actual jenkins build number #2500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
prudhvigodithi
approved these changes
Aug 23, 2022
|
The |
Codecov Report
@@ Coverage Diff @@
## main #2500 +/- ##
=========================================
Coverage 94.47% 94.47%
Complexity 27 27
=========================================
Files 218 218
Lines 4449 4449
Branches 29 29
=========================================
Hits 4203 4203
Misses 240 240
Partials 6 6 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
|
Hi @prudhvigodithi please review. I made the changes. Thanks! |
Closed
| @@ -98,7 +98,7 @@ pipeline { | |||
| uploadTestResults( | |||
| buildManifestFileName: BUILD_MANIFEST, | |||
| jobName: JOB_NAME | |||
| ) | |||
| ) | |||
| buildNumber: BUILD_ID | ||
| ) | ||
| jobName: JOB_NAME | ||
| ) |
peterzhuamazon
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sayali Gaikawad gaiksaya@amazon.com
Description
Looks like #2488 only fixed the message but not the actual path. This PR fixes the same for all tests.
The test_run_id was hardcoded to 1 for integ-test and bwc-test which now is changed to build_number of the job.
This will allow us to run any number of tests for same build_id without overwriting the results.
In case of performance tests since it is not integrated with test_recorder yet, the build_number is added as a part of the upload path.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.