Fix the path join for running integ test #3041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zelin Hao <zelinhao@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #3041 +/- ##
=======================================
Coverage 93.17% 93.17%
=======================================
Files 167 167
Lines 4602 4602
=======================================
Hits 4288 4288
Misses 314 314
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
dblock
reviewed
Jan 4, 2023
| @@ -37,6 +37,6 @@ def install_build_dependencies(self, dependency_dict: dict, dest: str) -> None: | |||
| """ | |||
| os.makedirs(dest, exist_ok=True) | |||
| for dependency, version in dependency_dict.items(): | |||
| path = f"{self.root_url}/builds/opensearch/plugins/{dependency}-{version}.zip" | |||
| path = os.path.join(self.root_url, f"builds/opensearch/plugins/{dependency}-{version}.zip") | |||
There was a problem hiding this comment.
I think you want to make this Windows compatible too here, I believe os.path.join(self.root_url, 'builds', 'opensearch', ...) should work.
NM, it's a URL, maybe it should not be called path :)
dblock
approved these changes
Jan 4, 2023
|
Add a unit test? |
Signed-off-by: Zelin Hao <zelinhao@amazon.com>
Yes, I just added another unit test for this situation when the URL has ending backslash. |
dblock
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zelin Hao zelinhao@amazon.com
Description
Fix the path by using
os.path.joininstead of hard connected. This would resolve the issue when there is a need to install dependency plugin for running tests.The origin error for the issue on installing maven artifacts was resolved earlier in this PR. #2892
Issues Resolved
#969
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.