add security-analytics to 2.5.0 manifest #3070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #3070 +/- ##
=======================================
Coverage 93.17% 93.17%
=======================================
Files 167 167
Lines 4602 4602
=======================================
Hits 4288 4288
Misses 314 314 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
getsaurabh02
approved these changes
Jan 10, 2023
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
gaiksaya
reviewed
Jan 10, 2023
manifests/2.5.0/opensearch-2.5.0.yml
Outdated
| - windows | ||
| checks: | ||
| - gradle:properties:version | ||
| - gradle:dependencies:opensearch.version |
There was a problem hiding this comment.
Looking at the past manifests, looks like security-analytics has only 1 check. https://github.com/opensearch-project/opensearch-build/blob/main/manifests/2.4.0/opensearch-2.4.0.yml#L161-L167
There was a problem hiding this comment.
thanks @gaiksaya . fixed it
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
gaiksaya
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Subhobrata Dey sbcd90@gmail.com
Description
add security-analytics to 2.5.0 manifest
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.