Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding 2.5.0 / 2.5.1 / 2.6.0 / 1.3.8/ 1.3.9 for perf-test #3204

Merged
merged 4 commits into from
Feb 16, 2023
Merged

Adding 2.5.0 / 2.5.1 / 2.6.0 / 1.3.8/ 1.3.9 for perf-test #3204

merged 4 commits into from
Feb 16, 2023

Conversation

jordarlu
Copy link
Contributor

@jordarlu jordarlu commented Feb 15, 2023

Description

Adding 2.5.0 / 2.5.1 / 2.6.0 / 1.3.8/ 1.3.9 for perf-test

Issues Resolved

This PR is for adding 2.5.0 / 2.5.1 / 2.6.0 / 1.3.8/ 1.3.9 for perf-test to execute

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Jeff Lu <chunglu@amazon.com>
@jordarlu jordarlu changed the title Adding 2.5.0 / 2.5.1 / 2.6.0 / 3.0 / 1.3.8/ 1.3.9 for perf-test Adding 2.5.0 / 2.5.1 / 2.6.0 / 1.3.8/ 1.3.9 for perf-test Feb 15, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2023

Codecov Report

Merging #3204 (8c1f43b) into main (ac7bd8f) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #3204   +/-   ##
=======================================
  Coverage   93.20%   93.20%           
=======================================
  Files         167      167           
  Lines        4622     4622           
=======================================
  Hits         4308     4308           
  Misses        314      314           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Jeff Lu <chunglu@amazon.com>
@jordarlu jordarlu marked this pull request as ready for review February 16, 2023 00:02
@jordarlu jordarlu requested a review from a team as a code owner February 16, 2023 00:02
@peterzhuamazon
Copy link
Member

Do we still need to keep the ones that is already out?
2.2.1/2.3.0, etc.

Thanks.

@@ -28,14 +40,22 @@ pipeline {
H 17 * * * %BUNDLE_MANIFEST_URL=https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/2.4.0/latest/linux/arm64/tar/dist/opensearch/manifest.yml;TEST_ITERATIONS=250;WARMUP_ITERATIONS=0
Copy link
Member

@bbarani bbarani Feb 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove older versions (i.e <2.4.0, <1.3.7)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @bbarani and @peterzhuamazon ... cool .. let me remove those already out ...

@jordarlu
Copy link
Contributor Author

Do we still need to keep the ones that is already out? 2.2.1/2.3.0, etc.

Thanks.

agh.. good question ... I think it makes sense to remove those already out .... also, easier to find a time slot between each build to run ... any objections from team?

Signed-off-by: Jeff Lu <chunglu@amazon.com>
Signed-off-by: Jeff Lu <chunglu@amazon.com>
@jordarlu
Copy link
Contributor Author

@peterzhuamazon , @bbarani , I have got older versions removed. Thanks in advance for your 2nd review !

@jordarlu jordarlu merged commit 4f20675 into opensearch-project:main Feb 16, 2023
@jordarlu jordarlu self-assigned this Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants