Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for dockerbuild #3221

Merged
merged 2 commits into from
Feb 22, 2023
Merged

Add check for dockerbuild #3221

merged 2 commits into from
Feb 22, 2023

Conversation

gaiksaya
Copy link
Member

@gaiksaya gaiksaya commented Feb 22, 2023

Description

This change is to ensure that anything that is pushed to any https://hub.docker.com/u/opensearchstaging is authored, reviewed and then pushed and build. Since the blast radius (even though in development) is high, we need to ensure the change is reviewed and has a source code.

check works as below:

Started by user [gaiksaya](https://ci-staging.opensearch.org/user/gaiksaya)
Obtained jenkins/docker/docker-build.jenkinsfile from git https://github.com/gaiksaya/opensearch-build
[Pipeline] Start of Pipeline
[Pipeline] timeout
Timeout set to expire in 3 hr 0 min
[Pipeline] {
[Pipeline] stage
[Pipeline] { (Parameters Check)
[Pipeline] script
[Pipeline] {
[Pipeline] error
[Pipeline] }
[Pipeline] // script
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (docker-build)
Stage "docker-build" skipped due to earlier failure(s)
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // timeout
[Pipeline] End of Pipeline
ERROR: The repository needs to be an opensearch-project repository
Finished: ABORTED

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
@gaiksaya gaiksaya requested a review from a team as a code owner February 22, 2023 01:20
@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2023

Codecov Report

Merging #3221 (163c956) into main (1a52215) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #3221   +/-   ##
=======================================
  Coverage   93.20%   93.20%           
=======================================
  Files         167      167           
  Lines        4622     4622           
=======================================
  Hits         4308     4308           
  Misses        314      314           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@prudhvigodithi
Copy link
Member

Hey @gaiksaya, thanks, LGTM, can you please check the failing groovy tests.

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
@gaiksaya
Copy link
Member Author

Hey @gaiksaya, thanks, LGTM, can you please check the failing groovy tests.

Fixed! Thanks!

@gaiksaya gaiksaya merged commit 00f36b9 into opensearch-project:main Feb 22, 2023
@gaiksaya gaiksaya deleted the docker branch February 22, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants