Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable tests with security for knn in 2.7.0 #3357

Conversation

martin-gaievski
Copy link
Member

Description

We need to disable tests with security for knn in 2.7.0 release.
Plugin tests need special adjustments for checks that security plugin start enforcing. Team has been working on solution from 2.6 (opensearch-project/security#2265), but this requires more effort/time. This is to unblock pipeline for other plugins/components.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Martin Gaievski <gaievski@amazon.com>
Copy link
Member

@gaiksaya gaiksaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @martin-gaievski ,

These tests are not blocker for any other components. each component runs independently and on separate server. Its fine if they fail. We want to keep track of what is failing and what is fixed. Adding @bbarani!

@bbarani
Copy link
Member

bbarani commented Apr 3, 2023

Hi @martin-gaievski ,

These tests are not blocker for any other components. each component runs independently and on separate server. Its fine if they fail. We want to keep track of what is failing and what is fixed. Adding @bbarani!

Yes, build failures are blocker but integration test failures are specific to your component and doesn't affect other components.

@gaiksaya gaiksaya closed this Apr 5, 2023
@gaiksaya
Copy link
Member

gaiksaya commented Apr 5, 2023

Closing the PR as we want to track the tests for k-NN at distribution level

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants