Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: write OpenSearch version without -SNAPSHOT into security plugin descriptor. #360

Merged
merged 1 commit into from
Sep 1, 2021

Conversation

dblock
Copy link
Member

@dblock dblock commented Aug 31, 2021

Signed-off-by: dblock dblock@dblock.org

Description

Always write a non-snapshot version of OpenSearch into the security plugin descriptor.

Issues Resolved

Fixes #359.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock dblock requested review from mch2 and peternied August 31, 2021 17:02
…descriptor.

Signed-off-by: dblock <dblock@dblock.org>
@codecov-commenter
Copy link

Codecov Report

Merging #360 (cd48193) into main (b038ee0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #360   +/-   ##
=======================================
  Coverage   53.63%   53.63%           
=======================================
  Files          29       29           
  Lines         785      785           
=======================================
  Hits          421      421           
  Misses        364      364           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b038ee0...cd48193. Read the comment docs.

@dblock dblock mentioned this pull request Sep 1, 2021
14 tasks
@dblock dblock merged commit 13e0971 into opensearch-project:main Sep 1, 2021
alborotogarcia pushed a commit to alborotogarcia/opensearch-build that referenced this pull request Sep 7, 2021
@dblock dblock deleted the fix-snapshot-assemble branch March 11, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Snapshot bundle cannot be assembled
4 participants