Trigger manifest check only for mentioned paths

[gaiksaya]

Description

Trigger manifest check only for mentioned paths. Currently they are triggered for all PRs. https://github.com/opensearch-project/opensearch-build/actions/workflows/manifests.yml and aborted later
Also fixes the badge in readme to green once the check are only related to actual run and not aborted ones

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (81dcc81) 91.35% compared to head (53f2d55) 91.35%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4355   +/-   ##
=======================================
  Coverage   91.35%   91.35%           
=======================================
  Files         190      190           
  Lines        6175     6175           
=======================================
  Hits         5641     5641           
  Misses        534      534           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Divyaasm]

We should now be able to trigger the manifests gh action only if PR contains manifest files from the provided paths. LGTM @gaiksaya

[peterzhuamazon]

I see these already present here:
dd41a58#diff-947e5f024300451482689c8e4260d039612c1926a9f5cdeadf4d508be652d9deL6

Also, I dont think we need to include legacy ones as that is the point of being legacy.

Thanks.

[gaiksaya]

I see these already present here: dd41a58#diff-947e5f024300451482689c8e4260d039612c1926a9f5cdeadf4d508be652d9deL6

Also, I dont think we need to include legacy ones as that is the point of being legacy.

Thanks.

The lines are missing from main workflow here: https://github.com/opensearch-project/opensearch-build/blob/main/.github/workflows/manifests.yml

I added legacy ones, just in case someone tries to make changes. We need the ci check to pass if we make any change to legacy manifest too. Won't hurt to keep the check.

[peterzhuamazon]

Seems like @zelinh PR mistakenly remove it here:
#4264

Thanks.

[zelinh]

Seems like @zelinh PR mistakenly remove it here: #4264

Thanks.

I think we did that on purpose. Since we run

        id: list-changed-manifests
        with:
          files: manifests/**/opensearch*.yml

the trigger there at front won't serve any purpose.

[peterzhuamazon]

Seems like @zelinh PR mistakenly remove it here: #4264
Thanks.

I think we did that on purpose. Since we run

        id: list-changed-manifests
        with:
          files: manifests/**/opensearch*.yml

the trigger there at front won't not serve any purpose.

Yeah, now I remember this now. Thanks.

[gaiksaya]

Seems like @zelinh PR mistakenly remove it here: #4264
Thanks.

I think we did that on purpose. Since we run

        id: list-changed-manifests
        with:
          files: manifests/**/opensearch*.yml

the trigger there at front won't not serve any purpose.

The workflows are still getting triggered. https://github.com/opensearch-project/opensearch-build/actions/workflows/manifests.yml

This will save resources. Only do checks if specific path is changed

[zelinh]

Sure makes sense for me. We could add this back.