Add Dashboards var for UI Metric Collectors #4666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LDrago27
requested review from
dblock,
peterzhuamazon,
bbarani,
gaiksaya,
rishabh6788,
zelinh,
jordarlu,
prudhvigodithi,
Divyaasm and
tianleh
as code owners
peterzhuamazon
requested changes
Apr 30, 2024
There was a problem hiding this comment.
Hi @LDrago27 ,
Please update these two configs with details on this change as well:
https://github.com/opensearch-project/opensearch-build/blob/main/config/opensearch_dashboards-2.x.yml
https://github.com/opensearch-project/opensearch-build/blob/main/config/opensearch_dashboards-default.x.yml
You can check the existing examples in comments.
Thanks.
Signed-off-by: Suchit Sahoo <suchsah@amazon.com>
|
Thanks @peterzhuamazon . I have updated the PR with the suggested changes. |
peterzhuamazon
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add OpensearchDashboard variables corresponding to UI Metric Collectors introduced in the given PR.
Issues Resolved
opensearch-project/OpenSearch-Dashboards#6203
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.