Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimumCompilerVersion check for manifest update on OpenSearch Min branches #4953

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented Aug 19, 2024

Description

Add minimumCompilerVersion check for manifest update on OpenSearch Min branches
Also moved a few older manifest to legacy folder as they are really old and do not need to create manifests anymore.

Issues Resolved

Closes #4952

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…n branches

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Copy link
Member

@gaiksaya gaiksaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! Can you please update the PR description mentioning manifest move to legacy?

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon peterzhuamazon merged commit f2d7b9c into opensearch-project:main Aug 20, 2024
12 checks passed
@peterzhuamazon peterzhuamazon deleted the manifest-workflow-minCompVer branch August 20, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[BUG] Manifest workflow failed due to increase of minimumCompileVersion of Java update in 2.x
4 participants