Fix the report workflow to work with ci-group #4960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zelin Hao <zelinhao@amazon.com>
Signed-off-by: Zelin Hao <zelinhao@amazon.com>
zelinh
requested review from
dblock,
peterzhuamazon,
gaiksaya,
rishabh6788,
prudhvigodithi,
Divyaasm and
tianleh
as code owners
peterzhuamazon
requested changes
Aug 21, 2024
gaiksaya
reviewed
Aug 21, 2024
| test_report_runner_data = test_report_runner.update_data() | ||
|
|
||
| self.assertEqual(len(test_report_runner_data["components"]), 9) | ||
| self.assertEqual(test_report_runner_data["components"][0]["name"], "OpenSearch-Dashboards-ci-group-1") |
There was a problem hiding this comment.
Can you also add assertions for all ci-groups? Until 9?
There was a problem hiding this comment.
Already assert the total number of components in the report manifest though. I would add assertions for all of them.
Signed-off-by: Zelin Hao <zelinhao@amazon.com>
zelinh
force-pushed
the
fix-report-cigroup
branch
from
34c16e9
to
d7803dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the report workflow to work with ci-group
Issues Resolved
#4943
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.