Fix: pop current directory after chdir. #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
force-pushed
the
fix-temp-delete
branch
from
b6011d5 to
bc01e17
Compare
Codecov Report
@@ Coverage Diff @@
## main #803 +/- ##
==========================================
+ Coverage 90.75% 90.84% +0.08%
==========================================
Files 78 78
Lines 2164 2162 -2
==========================================
Hits 1964 1964
+ Misses 200 198 -2
Continue to review full report at Codecov.
|
dblock
force-pushed
the
fix-temp-delete
branch
from
bc01e17 to
4d14da4
Compare
Signed-off-by: dblock <dblock@dblock.org>
dblock
force-pushed
the
fix-temp-delete
branch
from
4d14da4 to
197d497
Compare
Signed-off-by: dblock <dblock@amazon.com>
dblock
force-pushed
the
fix-temp-delete
branch
from
093bead to
2f81c4c
Compare
19 tasks
mch2
approved these changes
Oct 26, 2021
VachaShah
approved these changes
Oct 26, 2021
owaiskazi19
reviewed
Oct 26, 2021
| if chdir: | ||
| self.curdir = os.getcwd() | ||
| os.chdir(self.name) | ||
| else: |
There was a problem hiding this comment.
nit:
Suggested change
| else: | |
| self.curdir = None | |
| if chdir: | |
| self.curdir = os.getcwd() | |
| os.chdir(self.name) | |
There was a problem hiding this comment.
I personally don't love this because it assigns self.curdir twice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: dblock dblock@dblock.org
Description
On Windows deleting the current directory fails with a "this directory is used by another process" error. Move
chdirintoTemporaryDirectoryas an option and pop it.Issues Resolved
An error similar to #774 but reproduced more consistently.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.