Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added common-utils. #858

Merged
merged 1 commit into from
Nov 2, 2021
Merged

Conversation

dblock
Copy link
Member

@dblock dblock commented Nov 2, 2021

Signed-off-by: dblock dblock@amazon.com

Description

We forgot to include common-utils in the release template and to open issues in that repo. I manually did it in opensearch-project/common-utils#89

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: dblock <dblock@amazon.com>
@dblock dblock requested review from peternied and CEHENKLE November 2, 2021 18:22
@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2021

Codecov Report

Merging #858 (f1b1f9e) into main (1309c2e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #858   +/-   ##
=======================================
  Coverage   91.18%   91.18%           
=======================================
  Files          87       87           
  Lines        2370     2370           
=======================================
  Hits         2161     2161           
  Misses        209      209           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1309c2e...f1b1f9e. Read the comment docs.

Copy link
Member

@CEHENKLE CEHENKLE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@peternied peternied merged commit fa2ebcd into opensearch-project:main Nov 2, 2021
@dblock dblock deleted the common-utils branch November 5, 2021 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants