[BUG] fix vpc protocol field to match vpc original declaration
#168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Protocol column is INT32 in VPC doc but Athena create table uses BIGINT which I think our integration refers to VPC doc: https://docs.aws.amazon.com/vpc/latest/userguide/flow-logs.html#flow-log-records * Athena doc: https://docs.aws.amazon.com/athena/latest/ug/vpc-flow-logs.html * Integration code: https://github.com/opensearch-project/opensearch-catalog/blob/main/integrations/observability/amazon_vpc_flow/assets/create_table_vpc_schema-1.0.0.sql#L9 Signed-off-by: YANGDB <yang.db.dev@gmail.com>
YANG-DB
requested review from
bowenlan-amzn,
khushbr,
praveensameneni,
ananzh,
Swiddis and
AMoo-Miki
as code owners
YANG-DB
changed the title
protocol field to match vpc original declaration:protocol field to match vpc original declaration
Swiddis
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix vpc
protocolfield to match vpc original declaration:Issues Resolved
#167
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.