-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug Fix] Fix VPC's table creation query #196
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Swiddis
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@RyanL1997 I noticed that this one doesn't address
in the linked issue |
thanks @RyanL1997 ! |
Kevlw-AWS
pushed a commit
to Kevlw-AWS/opensearch-catalog-security
that referenced
this pull request
Dec 27, 2024
Signed-off-by: Ryan Liang <jiallian@amazon.com> Signed-off-by: Kevin Low <kevlw@amazon.com>
YANG-DB
added a commit
that referenced
this pull request
Jan 15, 2025
* Docker applicative network name getting started docker (#193) * add csv upload file integration Signed-off-by: YANGDB <yang.db.dev@gmail.com> * update csv_file getting started docker content Signed-off-by: YANGDB <yang.db.dev@gmail.com> * update fluent-bit index names getting started docker content Signed-off-by: YANGDB <yang.db.dev@gmail.com> * update fluent-bit index names getting started docker content Signed-off-by: YANGDB <yang.db.dev@gmail.com> --------- Signed-off-by: YANGDB <yang.db.dev@gmail.com> Signed-off-by: Kevin Low <kevlw@amazon.com> * Update README.md (#187) Signed-off-by: YANGDB <yang.db.dev@gmail.com> Signed-off-by: Kevin Low <kevlw@amazon.com> * first commit Signed-off-by: Kevin Low <kevlw@amazon.com> * first commit Signed-off-by: Kevin Low <kevlw@amazon.com> * aDded ocsf stuff Signed-off-by: Kevin Low <kevlw@amazon.com> * added init scripts and templates pointing to aliases Signed-off-by: Kevin Low <kevlw@amazon.com> * fixed init scripts Signed-off-by: Kevin Low <kevlw@amazon.com> * created init script Signed-off-by: Kevin Low <kevlw@amazon.com> * modified init scriot Signed-off-by: Kevin Low <kevlw@amazon.com> * made some changes Signed-off-by: Kevin Low <kevlw@amazon.com> * changed init script to put ISM policy first so that it will be associated properly Signed-off-by: Kevin Low <kevlw@amazon.com> * Update OSI-pipeline.yaml remove AWS account ID information. this is a no no! Signed-off-by: Kevin Low <kevlw@amazon.com> * minor changes for shard counts tweaks for the drop Signed-off-by: Kevin Low <kevlw@amazon.com> * added readme and json file for integration Signed-off-by: Kevin Low <kevlw@amazon.com> * fixed init script Signed-off-by: Kevin Low <kevlw@amazon.com> * updated readme Signed-off-by: Kevin Low <kevlw@amazon.com> * added ndjson Signed-off-by: Kevin Low <kevlw@amazon.com> * Bump org.json:json (#186) Bumps [org.json:json](https://github.com/douglascrockford/JSON-java) from 20210307 to 20231013. - [Release notes](https://github.com/douglascrockford/JSON-java/releases) - [Changelog](https://github.com/stleary/JSON-java/blob/master/docs/RELEASES.md) - [Commits](https://github.com/douglascrockford/JSON-java/commits) --- updated-dependencies: - dependency-name: org.json:json dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Kevin Low <kevlw@amazon.com> * modified readme Signed-off-by: Kevin Low <kevlw@amazon.com> * added the cfn scripts Signed-off-by: Kevin Low <kevlw@amazon.com> * added zip files Signed-off-by: Kevin Low <kevlw@amazon.com> * changed shard count to 1 Signed-off-by: Kevin Low <kevlw@amazon.com> * modified mappings Signed-off-by: Kevin Low <kevlw@amazon.com> * fixed 5001 Signed-off-by: Kevin Low <kevlw@amazon.com> * added modified init scripts Signed-off-by: Kevin Low <kevlw@amazon.com> * fixed init python function to work in lambda Signed-off-by: Kevin Low <kevlw@amazon.com> * got the init function working Signed-off-by: Kevin Low <kevlw@amazon.com> * standardised index templates with index.number of XX" Signed-off-by: Kevin Low <kevlw@amazon.com> * standardised the index templates with .index.number of xxx Signed-off-by: Kevin Low <kevlw@amazon.com> * updated mappings and readme Signed-off-by: Kevin Low <kevlw@amazon.com> * fixed readme Signed-off-by: Kevin Low <kevlw@amazon.com> * added cfn files Signed-off-by: Kevin Low <kevlw@amazon.com> * region parameter removed - thanks Jeremy for pointing it out! Signed-off-by: Kevin Low <kevlw@amazon.com> * Update Security-lake-objects.ndjson Remove ip addresses and make pathing relative Signed-off-by: Kevin Low <kevlw@amazon.com> * fixed unmapped in base-event Signed-off-by: Kevin Low <kevlw@amazon.com> * increased doc value fields in index templates to 4000 Signed-off-by: Kevin Low <kevlw@amazon.com> * modified saved objects and added two more index patterns Signed-off-by: Kevin Low <kevlw@amazon.com> * updated component templates Signed-off-by: Kevin Low <kevlw@amazon.com> * fixed data - text issues with component templates` ` Signed-off-by: Kevin Low <kevlw@amazon.com> * fixed typos Signed-off-by: Kevin Low <kevlw@amazon.com> * [Bug Fix] Fix VPC's table creation query (#196) Signed-off-by: Ryan Liang <jiallian@amazon.com> Signed-off-by: Kevin Low <kevlw@amazon.com> * added unmampped base event Signed-off-by: Kevin Low <kevlw@amazon.com> * made small changes to component and index templates to remove unmapped field from 2004 and 6003 Signed-off-by: Kevin Low <kevlw@amazon.com> * fixed OSI-pipeline.yaml Signed-off-by: Kevin Low <kevlw@amazon.com> * added init script with basic auth Signed-off-by: Kevin Low <kevlw@amazon.com> * cleaned up the scripts folder Signed-off-by: Kevin Low <kevlw@amazon.com> * updated OSI pipelines Signed-off-by: Kevin Low <kevlw@amazon.com> * modified script instructions Signed-off-by: Kevin Low <kevlw@amazon.com> * updated zip files Signed-off-by: Kevin Low <kevlw@amazon.com> * added readme Signed-off-by: Kevin Low <kevlw@amazon.com> * added images Signed-off-by: Kevin Low <kevlw@amazon.com> * modified images Signed-off-by: Kevin Low <kevlw@amazon.com> * updated readme Signed-off-by: Kevin Low <kevlw@amazon.com> * updated readme Signed-off-by: Kevin Low <kevlw@amazon.com> * updated readme Signed-off-by: Kevin Low <kevlw@amazon.com> * fixed images Signed-off-by: Kevin Low <kevlw@amazon.com> * added list of classes Signed-off-by: Kevin Low <kevlw@amazon.com> * Update readme.md relative path changes Signed-off-by: Kevin Low <kevlw@amazon.com> * updated folder structure to match the rest of the integrations Signed-off-by: Kevin Low <kevlw@amazon.com> * removed DS_store Signed-off-by: Kevin Low <kevlw@amazon.com> * removed .DS_store files from repo Signed-off-by: Kevin Low <kevlw@amazon.com> * updated readme with more verbose instructions around instlalation Signed-off-by: Kevin Low <kevlw@amazon.com> * made changes to conform to integration standard. Integration json still not working Signed-off-by: Kevin Low <kevlw@amazon.com> * updated format to follow integrations schema. Added OCSF-1.1.0.json file. Integration package can be built and imported but not accessed Signed-off-by: Kevin Low <kevlw@amazon.com> * modified ocsf.json to work. Requires the mappings from Apache, no clue why. OCSF mappings still not working --------- Signed-off-by: YANGDB <yang.db.dev@gmail.com> Signed-off-by: Kevin Low <kevlw@amazon.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Ryan Liang <jiallian@amazon.com> Co-authored-by: YANGDB <yang.db.dev@gmail.com> Co-authored-by: Kevin Fallis <57606623+kffallis@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jialiang Liang <jiallian@amazon.com> Co-authored-by: Kevin Fallis <kffallis@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe what this change achieves.
Fix VPC's table creation query
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.