Tracing schema typo #200
Open
Tracing schema typo #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: YANGDB <yang.db.dev@gmail.com>
…sue](opensearch-project#199) Signed-off-by: YANGDB <yang.db.dev@gmail.com>
YANG-DB
requested review from
bowenlan-amzn,
khushbr,
praveensameneni,
ananzh,
Swiddis and
AMoo-Miki
as code owners
Signed-off-by: YANGDB <yang.db.dev@gmail.com>
| } | ||
| } | ||
| } | ||
| "type": "keyword", |
There was a problem hiding this comment.
What is the actual difference between mapping for data streams and index patterns? is it only "data_stream": {}?
vamsimanohar
approved these changes
Nov 25, 2024
ps48
reviewed
Nov 25, 2024
Comment on lines
-108
to
-127
| "attributes": { | ||
| "type": "object", | ||
| "data_stream": { | ||
| "properties": { | ||
| "dataset": { | ||
| "ignore_above": 128, | ||
| "type": "keyword" | ||
| }, | ||
| "namespace": { | ||
| "ignore_above": 128, | ||
| "type": "keyword" | ||
| }, | ||
| "type": { | ||
| "ignore_above": 56, | ||
| "type": "keyword" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, |
There was a problem hiding this comment.
Will this break the OpenSearch OTEL exporter: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/5698c9def9352a1ea5ad9bc307265a4a04de9c1f/exporter/opensearchexporter/encoder.go#L187-L200
There was a problem hiding this comment.
Yes - I'll add this change under a new minor version
There was a problem hiding this comment.
@ps48 can you plz review again ?
thanks
Signed-off-by: YANGDB <yang.db.dev@gmail.com>
|
@Swiddis can you plz review ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
remove unnecessary
data_streammapping support form all signalsconverge
metric&metrics-datastreamindex templatesIssues Resolved
#199
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.