Stub visualization catalog with current Nginx visualizations #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Swiddis
requested review from
bowenlan-amzn,
khushbr,
praveensameneni,
ananzh,
seanneumann and
AMoo-Miki
as code owners
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
YANG-DB
requested changes
Jul 6, 2023
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
|
Any further review or updates? @YANG-DB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In relation to #33, this PR introduces a basic visualization catalog with an index in yml. The PR provides four visualizations based on the current Nginx integration. These visualizations have been renamed to not reference Nginx specifically. More invasive changes like unwrapping the dependency on referenced objects hasn't yet been done, I think there needs to be more research on the saved object format in order to improve that.
A point of further work is to figure out the exact structure of the index, and what kind of information it should contain.
Issues Resolved
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.