Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Vis Augmenter] Add tests in OSD & AD plugin #760

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 39444c1 from #752

* [Vis Augmenter / Feature Anywhere] Add test suite for vanilla OSD + helper fns for plugins (#725)

* feature anywhere initial tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Add test suite

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>

* Remove unnecessary test case

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>

* Optimize getters

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [Feature Anywhere / Vis Augmenter] Add test flows for integration with AD plugin (#727)

* feature anywhere initial tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Add test suite

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>

* Add AD vis augmenter tests

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>

* More refactoring

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>

* More tests

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>

* Add test for AD cleanup scenario

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>

* Set up saved obj test suite

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>

* Add reminder TODO

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>

* Add tests regarding saved obj visibility

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>

* Add view events tests

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>

* cleanup

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>

* remove import

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Fix NPE

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>

* Fix bug of non-empty dashboard; remove unnecessary test

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>

* Simplify dashboard creation

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>

* Update undefined check

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
(cherry picked from commit 39444c1)
@SuZhou-Joe
Copy link
Member

Approved in advance, but the flow failed by infra bundle.

@ohltyler
Copy link
Member

@SuZhou-Joe the failing workflows will probably stay failing until all repos have version bumped to 2.10. But it is passing on 2.9 PR. Can we merge?

@SuZhou-Joe SuZhou-Joe merged commit 6e9bb39 into 2.x Jul 18, 2023
@github-actions github-actions bot deleted the backport/backport-752-to-2.x branch July 18, 2023 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants