[Backport main] Buffer waitForLoader before checking for icon
#859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
Some async calls occur after navigating and sometimes navigating too quickly prevents the calls from having correct data and therefore the homeIcon is in a bad state. This adds the ability to buffer before checking for the homeIcon. Defaulted to 0 ms, but for `yarn cypress:run-with-security` configures WAIT_FOR_LOADER_BUFFER_MS to be 500 ms Issue resolved: opensearch-project/OpenSearch-Dashboards#5028 Signed-off-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit e7c7e59)
opensearch-trigger-bot
bot
requested review from
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam and
raintygao
as code owners
kavilla
approved these changes
Sep 15, 2023
ananzh
approved these changes
Sep 18, 2023
leanneeliatra
pushed a commit
to leanneeliatra/opensearch-dashboards-functional-test-fork
that referenced
this pull request
Sep 29, 2023
…) (opensearch-project#859) Some async calls occur after navigating and sometimes navigating too quickly prevents the calls from having correct data and therefore the homeIcon is in a bad state. This adds the ability to buffer before checking for the homeIcon. Defaulted to 0 ms, but for `yarn cypress:run-with-security` configures WAIT_FOR_LOADER_BUFFER_MS to be 500 ms Issue resolved: opensearch-project/OpenSearch-Dashboards#5028 Signed-off-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit e7c7e59) Co-authored-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com>
ruanyl
added a commit
that referenced
this pull request
Oct 10, 2023
…ain tenant in shortlink (#736) * Test to ensure when a shortlink is copied, tenant is changed and short link is visited. The tenant from the link is visited. Signed-off-by: leanneeliatra <leanne.laceybyrne@eliatra.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * After link copy, allow tenant change Signed-off-by: leanneeliatra <leanne.laceybyrne@eliatra.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * Addressing comments, removing function to it's own file and removing unneeded code in before. Signed-off-by: leanneeliatra <leanne.laceybyrne@eliatra.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * Spelling error rectified Signed-off-by: leanneeliatra <leanne.laceybyrne@eliatra.com> Signed-off-by: leanneeliatra <leanne.laceybyrne@eliatra.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * Linting errors resolved Signed-off-by: leanneeliatra <leanne.laceybyrne@eliatra.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * Update cypress/utils/commands.js Co-authored-by: Yulong Ruan <ruanyu1@gmail.com> Signed-off-by: leanneeliatra <131779422+leanneeliatra@users.noreply.github.com> Signed-off-by: leanneeliatra <leanne.laceybyrne@eliatra.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * Changed data-test-subj to getElementByTestId for consitency Signed-off-by: leanneeliatra <leanne.laceybyrne@eliatra.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * Switch tenant updated to use interceps and should() for improved test performance Signed-off-by: leanneeliatra <leanne.laceybyrne@eliatra.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * switch tenant changed to use intercepts and should() for increaced test performance. Signed-off-by: leanneeliatra <leanne.laceybyrne@eliatra.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * Adding commen to explain how the addtion of the should() helps Signed-off-by: leanneeliatra <leanne.laceybyrne@eliatra.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * Global declaration of the tenant removed. The clearing of session storage is not needed actually, cy.visit() does this for us Signed-off-by: leanneeliatra <leanne.laceybyrne@eliatra.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * Additition of 'createDashboard' method to allow programatic dashboard creation. Also improvements to the test. Signed-off-by: leanneeliatra <leanne.laceybyrne@eliatra.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * When testing we are looking for the private tenant. Signed-off-by: leanneeliatra <leanne.laceybyrne@eliatra.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * check changed to allow for both 'private' and __user__ Signed-off-by: leanneeliatra <leanne.laceybyrne@eliatra.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * linting errors resolved Signed-off-by: leanneeliatra <leanne.laceybyrne@eliatra.com> Signed-off-by: leanneeliatra <leanne.laceybyrne@eliatra.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * merging in changes on remote Signed-off-by: leanneeliatra <leanne.laceybyrne@eliatra.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * Adding back --headless parameter. Signed-off-by: leanneeliatra <leanne.laceybyrne@eliatra.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * undoing package-lock changes. Signed-off-by: leanneeliatra <leanne.laceybyrne@eliatra.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * Use library from release tag instead of git reference (#706) The module installed from the OSD test library seems to update or not based on caching issues. Related proposal: opensearch-project/opensearch-dashboards-test-library#36 Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * update testSplitTables test (#731) Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * [Vis Augmenter / Feature Anywhere] Add tests in core OSD and AD plugin (#739) * [Vis Augmenter / Feature Anywhere] Add test suite for vanilla OSD + helper fns for plugins (#725) * feature anywhere initial tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Add test suite Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Remove unnecessary test case Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Optimize getters Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [Feature Anywhere / Vis Augmenter] Add test flows for integration with AD plugin (#727) * feature anywhere initial tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Add test suite Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Add AD vis augmenter tests Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * More refactoring Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * More tests Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Add test for AD cleanup scenario Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Set up saved obj test suite Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Add reminder TODO Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Add tests regarding saved obj visibility Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Add view events tests Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * cleanup Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * remove import Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * Revert "[Vis Augmenter / Feature Anywhere] Add tests in core OSD and AD plugin (#739)" (#748) This reverts commit 07a67d7. Signed-off-by: manasvinibs <manasvis@amazon.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * Test sample data with multiple data source enabled on local cluster (#756) Signed-off-by: Kristen Tian <tyarong@amazon.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * [Vis Augmenter] Add tests in OSD & AD plugin (#752) * [Vis Augmenter / Feature Anywhere] Add test suite for vanilla OSD + helper fns for plugins (#725) * feature anywhere initial tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Add test suite Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Remove unnecessary test case Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Optimize getters Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [Feature Anywhere / Vis Augmenter] Add test flows for integration with AD plugin (#727) * feature anywhere initial tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Add test suite Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Add AD vis augmenter tests Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * More refactoring Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * More tests Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Add test for AD cleanup scenario Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Set up saved obj test suite Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Add reminder TODO Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Add tests regarding saved obj visibility Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Add view events tests Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * cleanup Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * remove import Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Fix NPE Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Fix bug of non-empty dashboard; remove unnecessary test Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Simplify dashboard creation Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Update undefined check Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * fix: CVE of tough-cookie and word-wrap (#763) Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * feat: use "overrides" to install desired version of tough-cookie and word-wrap. (#772) * feat: use npm v8 to install and initialize package-lock Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add Node version requirement in DEVELOPER_GUIDE Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * Improve date selection across versions of OUI (#778) Signed-off-by: Miki <miki@amazon.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * feat: sync cypress test from notifications-dashboards (#776) (#784) * feat: sync cypress test from notifications-dashboards Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: rename commands Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add larger wait time Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add refresh before delete all notifications configs Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> (cherry picked from commit 81f70c3) Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * [Table Visualizations] Tests cleanup (#785) Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * Bump dependency on opensearch-dashboards-test-library (#790) Signed-off-by: Miki <miki@amazon.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * [Table Visualizations] Test Update (#787) * fix-test * simplify selector --------- Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * fix discover (#803) Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * Change to toast message in Reports (#578) * Change to toast message in Reports download spec Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> * Update test Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> * Fix lint Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> --------- Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * fix discover (#807) Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * feat: add test cases for remote models (#813) Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * fix workbench download text and csv schema (#814) (#817) Signed-off-by: Joshua Li <joshuali925@gmail.com> (cherry picked from commit 46c0882) Co-authored-by: Joshua Li <joshuali925@gmail.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * update trace analytics cypress tests according to observability changes (#775) * update ftr Signed-off-by: Derek Ho <dxho@amazon.com> * revert file Signed-off-by: Derek Ho <dxho@amazon.com> * update with trace analytics accordian changes Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * Bump semver from 7.3.7 to 7.5.4 (#822) Bumps [semver](https://github.com/npm/node-semver) from 7.3.7 to 7.5.4. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/main/CHANGELOG.md) - [Commits](npm/node-semver@v7.3.7...v7.5.4) --- updated-dependencies: - dependency-name: semver dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * [Dashboard] Retry visbuilder dashboard test (#823) Seeing it pass in video replays but occassionally doesn't pass. However, it doesn't pass with security enabled so I'd imagine it could be related to the refreshing of the session. Issue: opensearch-project/OpenSearch-Dashboards#4947 Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * Add new tests for alerting dashboards (#832) Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * Update source element in import_vector_map_tab.spec.js (#844) * Update source element in import_vector_map_tab.spec.js Signed-off-by: Junqiu Lei <junqiu@amazon.com> * Update source element in import_vector_map_tab.spec.js Signed-off-by: Junqiu Lei <junqiu@amazon.com> --------- Signed-off-by: Junqiu Lei <junqiu@amazon.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * Use index pattern id to find page in import_vector_map_tab.spec.js (#847) Signed-off-by: Junqiu Lei <junqiu@amazon.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * Buffer `waitForLoader` before checking for icon (#857) (#859) Some async calls occur after navigating and sometimes navigating too quickly prevents the calls from having correct data and therefore the homeIcon is in a bad state. This adds the ability to buffer before checking for the homeIcon. Defaulted to 0 ms, but for `yarn cypress:run-with-security` configures WAIT_FOR_LOADER_BUFFER_MS to be 500 ms Issue resolved: opensearch-project/OpenSearch-Dashboards#5028 Signed-off-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit e7c7e59) Co-authored-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * Overwrite removed and moved to after in unit test Signed-off-by: leanneeliatra <leanne.laceybyrne@eliatra.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * Update dashboard.spec.js Signed-off-by: leanneeliatra <131779422+leanneeliatra@users.noreply.github.com> * Update dashboard_sample_data_spec.js remove unneeded change Signed-off-by: leanneeliatra <131779422+leanneeliatra@users.noreply.github.com> --------- Signed-off-by: leanneeliatra <leanne.laceybyrne@eliatra.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> Signed-off-by: leanneeliatra <131779422+leanneeliatra@users.noreply.github.com> Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz> Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> Signed-off-by: manasvinibs <manasvis@amazon.com> Signed-off-by: Kristen Tian <tyarong@amazon.com> Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: Miki <miki@amazon.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com> Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Signed-off-by: Junqiu Lei <junqiu@amazon.com> Co-authored-by: Yulong Ruan <ruanyu1@gmail.com> Co-authored-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz> Co-authored-by: Tyler Ohlsen <ohltyler@amazon.com> Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> Co-authored-by: Manasvini B Suryanarayana <manasvis@amazon.com> Co-authored-by: Kristen Tian <105667444+kristenTian@users.noreply.github.com> Co-authored-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: Miki <amoo_miki@yahoo.com> Co-authored-by: Miki <miki@amazon.com> Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com> Co-authored-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> Co-authored-by: Lin Wang <wonglam@amazon.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: Derek Ho <derek01778@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ashish Agrawal <ashish81394@gmail.com> Co-authored-by: Junqiu Lei <junqiu@amazon.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 10, 2023
…ain tenant in shortlink (#736) * Test to ensure when a shortlink is copied, tenant is changed and short link is visited. The tenant from the link is visited. Signed-off-by: leanneeliatra <leanne.laceybyrne@eliatra.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * After link copy, allow tenant change Signed-off-by: leanneeliatra <leanne.laceybyrne@eliatra.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * Addressing comments, removing function to it's own file and removing unneeded code in before. Signed-off-by: leanneeliatra <leanne.laceybyrne@eliatra.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * Spelling error rectified Signed-off-by: leanneeliatra <leanne.laceybyrne@eliatra.com> Signed-off-by: leanneeliatra <leanne.laceybyrne@eliatra.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * Linting errors resolved Signed-off-by: leanneeliatra <leanne.laceybyrne@eliatra.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * Update cypress/utils/commands.js Co-authored-by: Yulong Ruan <ruanyu1@gmail.com> Signed-off-by: leanneeliatra <131779422+leanneeliatra@users.noreply.github.com> Signed-off-by: leanneeliatra <leanne.laceybyrne@eliatra.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * Changed data-test-subj to getElementByTestId for consitency Signed-off-by: leanneeliatra <leanne.laceybyrne@eliatra.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * Switch tenant updated to use interceps and should() for improved test performance Signed-off-by: leanneeliatra <leanne.laceybyrne@eliatra.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * switch tenant changed to use intercepts and should() for increaced test performance. Signed-off-by: leanneeliatra <leanne.laceybyrne@eliatra.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * Adding commen to explain how the addtion of the should() helps Signed-off-by: leanneeliatra <leanne.laceybyrne@eliatra.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * Global declaration of the tenant removed. The clearing of session storage is not needed actually, cy.visit() does this for us Signed-off-by: leanneeliatra <leanne.laceybyrne@eliatra.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * Additition of 'createDashboard' method to allow programatic dashboard creation. Also improvements to the test. Signed-off-by: leanneeliatra <leanne.laceybyrne@eliatra.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * When testing we are looking for the private tenant. Signed-off-by: leanneeliatra <leanne.laceybyrne@eliatra.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * check changed to allow for both 'private' and __user__ Signed-off-by: leanneeliatra <leanne.laceybyrne@eliatra.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * linting errors resolved Signed-off-by: leanneeliatra <leanne.laceybyrne@eliatra.com> Signed-off-by: leanneeliatra <leanne.laceybyrne@eliatra.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * merging in changes on remote Signed-off-by: leanneeliatra <leanne.laceybyrne@eliatra.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * Adding back --headless parameter. Signed-off-by: leanneeliatra <leanne.laceybyrne@eliatra.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * undoing package-lock changes. Signed-off-by: leanneeliatra <leanne.laceybyrne@eliatra.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * Use library from release tag instead of git reference (#706) The module installed from the OSD test library seems to update or not based on caching issues. Related proposal: opensearch-project/opensearch-dashboards-test-library#36 Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * update testSplitTables test (#731) Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * [Vis Augmenter / Feature Anywhere] Add tests in core OSD and AD plugin (#739) * [Vis Augmenter / Feature Anywhere] Add test suite for vanilla OSD + helper fns for plugins (#725) * feature anywhere initial tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Add test suite Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Remove unnecessary test case Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Optimize getters Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [Feature Anywhere / Vis Augmenter] Add test flows for integration with AD plugin (#727) * feature anywhere initial tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Add test suite Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Add AD vis augmenter tests Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * More refactoring Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * More tests Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Add test for AD cleanup scenario Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Set up saved obj test suite Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Add reminder TODO Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Add tests regarding saved obj visibility Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Add view events tests Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * cleanup Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * remove import Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * Revert "[Vis Augmenter / Feature Anywhere] Add tests in core OSD and AD plugin (#739)" (#748) This reverts commit 07a67d7. Signed-off-by: manasvinibs <manasvis@amazon.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * Test sample data with multiple data source enabled on local cluster (#756) Signed-off-by: Kristen Tian <tyarong@amazon.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * [Vis Augmenter] Add tests in OSD & AD plugin (#752) * [Vis Augmenter / Feature Anywhere] Add test suite for vanilla OSD + helper fns for plugins (#725) * feature anywhere initial tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Add test suite Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Remove unnecessary test case Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Optimize getters Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [Feature Anywhere / Vis Augmenter] Add test flows for integration with AD plugin (#727) * feature anywhere initial tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Add test suite Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Add AD vis augmenter tests Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * More refactoring Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * More tests Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Add test for AD cleanup scenario Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Set up saved obj test suite Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Add reminder TODO Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Add tests regarding saved obj visibility Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Add view events tests Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * cleanup Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * remove import Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Fix NPE Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Fix bug of non-empty dashboard; remove unnecessary test Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Simplify dashboard creation Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Update undefined check Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * fix: CVE of tough-cookie and word-wrap (#763) Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * feat: use "overrides" to install desired version of tough-cookie and word-wrap. (#772) * feat: use npm v8 to install and initialize package-lock Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add Node version requirement in DEVELOPER_GUIDE Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * Improve date selection across versions of OUI (#778) Signed-off-by: Miki <miki@amazon.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * feat: sync cypress test from notifications-dashboards (#776) (#784) * feat: sync cypress test from notifications-dashboards Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: rename commands Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add larger wait time Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add refresh before delete all notifications configs Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> (cherry picked from commit 81f70c3) Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * [Table Visualizations] Tests cleanup (#785) Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * Bump dependency on opensearch-dashboards-test-library (#790) Signed-off-by: Miki <miki@amazon.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * [Table Visualizations] Test Update (#787) * fix-test * simplify selector --------- Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * fix discover (#803) Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * Change to toast message in Reports (#578) * Change to toast message in Reports download spec Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> * Update test Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> * Fix lint Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> --------- Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * fix discover (#807) Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * feat: add test cases for remote models (#813) Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * fix workbench download text and csv schema (#814) (#817) Signed-off-by: Joshua Li <joshuali925@gmail.com> (cherry picked from commit 46c0882) Co-authored-by: Joshua Li <joshuali925@gmail.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * update trace analytics cypress tests according to observability changes (#775) * update ftr Signed-off-by: Derek Ho <dxho@amazon.com> * revert file Signed-off-by: Derek Ho <dxho@amazon.com> * update with trace analytics accordian changes Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * Bump semver from 7.3.7 to 7.5.4 (#822) Bumps [semver](https://github.com/npm/node-semver) from 7.3.7 to 7.5.4. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/main/CHANGELOG.md) - [Commits](npm/node-semver@v7.3.7...v7.5.4) --- updated-dependencies: - dependency-name: semver dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * [Dashboard] Retry visbuilder dashboard test (#823) Seeing it pass in video replays but occassionally doesn't pass. However, it doesn't pass with security enabled so I'd imagine it could be related to the refreshing of the session. Issue: opensearch-project/OpenSearch-Dashboards#4947 Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * Add new tests for alerting dashboards (#832) Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * Update source element in import_vector_map_tab.spec.js (#844) * Update source element in import_vector_map_tab.spec.js Signed-off-by: Junqiu Lei <junqiu@amazon.com> * Update source element in import_vector_map_tab.spec.js Signed-off-by: Junqiu Lei <junqiu@amazon.com> --------- Signed-off-by: Junqiu Lei <junqiu@amazon.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * Use index pattern id to find page in import_vector_map_tab.spec.js (#847) Signed-off-by: Junqiu Lei <junqiu@amazon.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * Buffer `waitForLoader` before checking for icon (#857) (#859) Some async calls occur after navigating and sometimes navigating too quickly prevents the calls from having correct data and therefore the homeIcon is in a bad state. This adds the ability to buffer before checking for the homeIcon. Defaulted to 0 ms, but for `yarn cypress:run-with-security` configures WAIT_FOR_LOADER_BUFFER_MS to be 500 ms Issue resolved: opensearch-project/OpenSearch-Dashboards#5028 Signed-off-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit e7c7e59) Co-authored-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * Overwrite removed and moved to after in unit test Signed-off-by: leanneeliatra <leanne.laceybyrne@eliatra.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> * Update dashboard.spec.js Signed-off-by: leanneeliatra <131779422+leanneeliatra@users.noreply.github.com> * Update dashboard_sample_data_spec.js remove unneeded change Signed-off-by: leanneeliatra <131779422+leanneeliatra@users.noreply.github.com> --------- Signed-off-by: leanneeliatra <leanne.laceybyrne@eliatra.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com> Signed-off-by: leanneeliatra <131779422+leanneeliatra@users.noreply.github.com> Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz> Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> Signed-off-by: manasvinibs <manasvis@amazon.com> Signed-off-by: Kristen Tian <tyarong@amazon.com> Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: Miki <miki@amazon.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com> Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Signed-off-by: Junqiu Lei <junqiu@amazon.com> Co-authored-by: Yulong Ruan <ruanyu1@gmail.com> Co-authored-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz> Co-authored-by: Tyler Ohlsen <ohltyler@amazon.com> Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> Co-authored-by: Manasvini B Suryanarayana <manasvis@amazon.com> Co-authored-by: Kristen Tian <105667444+kristenTian@users.noreply.github.com> Co-authored-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: Miki <amoo_miki@yahoo.com> Co-authored-by: Miki <miki@amazon.com> Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com> Co-authored-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> Co-authored-by: Lin Wang <wonglam@amazon.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: Derek Ho <derek01778@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ashish Agrawal <ashish81394@gmail.com> Co-authored-by: Junqiu Lei <junqiu@amazon.com> (cherry picked from commit 21bf25f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport e7c7e59 from #857