Add wait time after selecting a color #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heemin32
requested review from
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam and
raintygao
as code owners
Signed-off-by: Heemin Kim <heemin@amazon.com>
CCongWang
approved these changes
Oct 25, 2023
|
There are some issues in workflow unrelated to this PR, tests passed locally, will merge |
ohltyler
approved these changes
Oct 25, 2023
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-936-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d97e8916090174df8719af81f3d77d546ee4b5b5
# Push it to GitHub
git push --set-upstream origin backport/backport-936-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.xThen, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.11 2.11
# Navigate to the new working tree
cd .worktrees/backport-2.11
# Create a new branch
git switch --create backport/backport-936-to-2.11
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d97e8916090174df8719af81f3d77d546ee4b5b5
# Push it to GitHub
git push --set-upstream origin backport/backport-936-to-2.11
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.11Then, create a pull request where the |
heemin32
added a commit
to heemin32/opensearch-dashboards-functional-test
that referenced
this pull request
Oct 25, 2023
Signed-off-by: Heemin Kim <heemin@amazon.com> (cherry picked from commit d97e891)
heemin32
added a commit
to heemin32/opensearch-dashboards-functional-test
that referenced
this pull request
Oct 25, 2023
Signed-off-by: Heemin Kim <heemin@amazon.com> (cherry picked from commit d97e891)
heemin32
added a commit
to heemin32/opensearch-dashboards-functional-test
that referenced
this pull request
Oct 25, 2023
Signed-off-by: Heemin Kim <heemin@amazon.com> (cherry picked from commit d97e891)
heemin32
added a commit
to heemin32/opensearch-dashboards-functional-test
that referenced
this pull request
Oct 25, 2023
Signed-off-by: Heemin Kim <heemin@amazon.com> (cherry picked from commit d97e891)
heemin32
added a commit
to heemin32/opensearch-dashboards-functional-test
that referenced
this pull request
Oct 25, 2023
Signed-off-by: Heemin Kim <heemin@amazon.com> (cherry picked from commit d97e891)
CCongWang
pushed a commit
that referenced
this pull request
Oct 25, 2023
CCongWang
pushed a commit
that referenced
this pull request
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After selecting a color from color palette, it takes time for the palette to disappear and it could cause two palette to be visible at the same time which could cause an error like
Your subject contained 2 elements.Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.