opensearchapi: Fix handling of errors without error response body #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com>
Jakob3xD
force-pushed
the
bug-empty-error
branch
from
027afa9 to
c77e1b8
Compare
dblock
approved these changes
Apr 10, 2023
| @@ -22,7 +22,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) | |||
| - Adds InfoResp type ([#253](https://github.com/opensearch-project/opensearch-go/pull/253)) | |||
| - Adds markdown linter ([#261](https://github.com/opensearch-project/opensearch-go/pull/261)) | |||
| - Adds testcases to check upsert functionality ([#207](https://github.com/opensearch-project/opensearch-go/issues/207)) | |||
| - Added @Jakob3xD to co-maintainers ([#270](https://github.com/opensearch-project/opensearch-go/pull/270)) | |||
zethuman
pushed a commit
to zethuman/opensearch-go
that referenced
this pull request
Apr 12, 2023
…ensearch-project#286) Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com>
zethuman
pushed a commit
to zethuman/opensearch-go
that referenced
this pull request
Apr 12, 2023
…ensearch-project#286) Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com> Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com>
zethuman
pushed a commit
to zethuman/opensearch-go
that referenced
this pull request
Apr 12, 2023
…ensearch-project#286) Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com>
zethuman
pushed a commit
to zethuman/opensearch-go
that referenced
this pull request
Apr 12, 2023
…ensearch-project#286) Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com> Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com>
zethuman
pushed a commit
to zethuman/opensearch-go
that referenced
this pull request
Apr 12, 2023
…ensearch-project#286) Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com>
zethuman
pushed a commit
to zethuman/opensearch-go
that referenced
this pull request
Apr 12, 2023
…ensearch-project#286) Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com> Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com>
zethuman
pushed a commit
to zethuman/opensearch-go
that referenced
this pull request
Apr 12, 2023
…ensearch-project#286) Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com>
zethuman
pushed a commit
to zethuman/opensearch-go
that referenced
this pull request
Apr 12, 2023
…ensearch-project#286) Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com> Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com>
zethuman
pushed a commit
to zethuman/opensearch-go
that referenced
this pull request
Apr 12, 2023
…ensearch-project#286) Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com>
zethuman
pushed a commit
to zethuman/opensearch-go
that referenced
this pull request
Apr 12, 2023
…ensearch-project#286) Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com> Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com>
zethuman
pushed a commit
to zethuman/opensearch-go
that referenced
this pull request
Apr 12, 2023
…ensearch-project#286) Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com>
zethuman
pushed a commit
to zethuman/opensearch-go
that referenced
this pull request
Apr 12, 2023
…ensearch-project#286) Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com> Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com>
dblock
added a commit
that referenced
this pull request
Apr 14, 2023
* Added @Jakob3xD as a co-maintainer. (#270) Signed-off-by: dblock <dblock@amazon.com> Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com> * Bump github.com/aws/aws-sdk-go from 1.44.230 to 1.44.235 (#271) * Bump github.com/aws/aws-sdk-go from 1.44.230 to 1.44.235 Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.230 to 1.44.235. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Commits](aws/aws-sdk-go@v1.44.230...v1.44.235) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Update changelog Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com> * Add markdown linter (#261) * Add linter for markdown files Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com> * Updated CHANGELOG.md Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com> * Add make-script and update DEVELOPER_GUIDE.md Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com> * Updated linter options Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com> * Fixed mmarkdown files format Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com> --------- Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com> * Added Jakob3xD to CODEOWNERS, removed @svencowart. (#272) Signed-off-by: dblock <dblock@amazon.com> Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com> * Add index_lifecycle guide Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com> * Updated CHANGELOG.md Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com> * opensearchapi: Fix handling of errors without error response body (#286) Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com> Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com> * Add bulk guide Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com> * Update CHANGELOG.md Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com> * Add document_lifecycle guide Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com> * Add indent to go code Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com> * Add indent to go code Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com> --------- Signed-off-by: dblock <dblock@amazon.com> Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com> Co-authored-by: Daniel (dB.) Doubrovkine <dblock@dblock.org> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Co-authored-by: Jakob <jakob.hahn@hetzner.com>
dblock
added a commit
that referenced
this pull request
Apr 14, 2023
* Add bulk guide Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com> * Updated CHANGELOG.md Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com> * opensearchapi: Fix handling of errors without error response body (#286) Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com> Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com> --------- Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com> Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com> Co-authored-by: Jakob <jakob.hahn@hetzner.com> Co-authored-by: Daniel (dB.) Doubrovkine <dblock@dblock.org>
dblock
added a commit
that referenced
this pull request
Apr 14, 2023
* Add search guide Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com> * Updated CHANGELOG.md Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com> * opensearchapi: Fix handling of errors without error response body (#286) Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com> Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com> --------- Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com> Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com> Co-authored-by: Jakob <jakob.hahn@hetzner.com> Co-authored-by: Daniel (dB.) Doubrovkine <dblock@dblock.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
Closes #281
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.