Remove references to the default credentials of admin:admin #449
Conversation
derek-ho
requested review from
dblock,
VijayanB,
VachaShah and
Jakob3xD
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #449 +/- ##
=======================================
Coverage 57.26% 57.26%
=======================================
Files 315 315
Lines 9823 9823
=======================================
Hits 5625 5625
Misses 2904 2904
Partials 1294 1294
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
@dblock can you take another look here? I am not sure why the tests against the latest secure cluster are passing, since the password changes should not be there? I also think the unit test failure is unrelated? |
.ci/opensearch/Dockerfile.opensearch
Outdated
| ENV password="admin" | ||
| RUN if [ "$OPENSEARCH_VERSION" = "latest" ]; then \ | ||
| export password="myStrongPassword123!"; \ | ||
| fi |
There was a problem hiding this comment.
This will break immediately after 2.12 is released.
There was a problem hiding this comment.
@derek-ho this should be updated to check for versions 2.12 and above
|
This change is not necessary until after release, seems like overall CI is healthy. Marking this until draft until after the release. |
|
@dblock @VijayanB @VachaShah @Jakob3xD Now that 2.12 is released this should be unblocked. Would one of you mind bringing this home? |
Sure! @derek-ho Is this ready for review now? |
|
@Jakob3xD thanks. I'm getting a little stuck on this PR since it seems by the time we reach here we have no context in regards to the OpenSearch version, since that is spun up as a different step. Any ideas? |
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com>
Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com>
I hope it is okay that I force pushed into your branch. I adjusted the docker file to fix the health check and change the go security check to find the password by trying them out. Otherwise we need to adjust the workflow to export the opensearch version as env so we can parse it as you tried before. |
Description
Remove references to the default credentials of admin:admin and changes the CI according to default admin credentials changes for the 2.12.0 release.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.