fix:Clusters deployed using IPV6 do not support the DiscoverNodes method #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zhang-jie-jun
requested review from
dblock,
VijayanB,
VachaShah and
Jakob3xD
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #461 +/- ##
==========================================
+ Coverage 57.25% 57.26% +0.01%
==========================================
Files 315 315
Lines 9820 9823 +3
==========================================
+ Hits 5622 5625 +3
Misses 2904 2904
Partials 1294 1294
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Jakob3xD
reviewed
Jan 19, 2024
|
LGTM, only thing missing is the DCO. Can you please sign your commits. |
…ter deployed with IPV6, an access error will occur when calling other APIs after calling the DiscoverNodes method. opensearch-project#458 Signed-off-by: 张洁俊 <82801500+Zhang-jie-jun@users.noreply.github.com> Signed-off-by: 张洁俊（Jack） <zhang.jiejun@outlook.com>
Signed-off-by: 张洁俊（Jack） <zhang.jiejun@outlook.com>
Signed-off-by: 张洁俊（Jack） <zhang.jiejun@outlook.com>
Signed-off-by: 张洁俊（Jack） <zhang.jiejun@outlook.com>
Signed-off-by: 张洁俊（Jack） <zhang.jiejun@outlook.com>
Signed-off-by: 张洁俊（Jack） <zhang.jiejun@outlook.com>
Signed-off-by: 张洁俊（Jack） <zhang.jiejun@outlook.com>
Signed-off-by: 张洁俊（Jack） <zhang.jiejun@outlook.com>
|
Jakob3xD
approved these changes
Jan 24, 2024
|
Thanks for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using the opensearch-go library to access an opensearch cluster deployed with IPV6, an access error will occur when calling other APIs after calling the DiscoverNodes method.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.