Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparing for next developer iteration, 3.1.1. #498

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

dblock
Copy link
Member

@dblock dblock commented Apr 1, 2024

Description

Preparing for next developer iteration, 3.1.1.

Waiting on https://pkg.go.dev/github.com/opensearch-project/opensearch-go/v3

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: dblock <dblock@amazon.com>
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.26%. Comparing base (c4c9bf3) to head (42a0ab1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #498   +/-   ##
=======================================
  Coverage   57.26%   57.26%           
=======================================
  Files         315      315           
  Lines        9823     9823           
=======================================
  Hits         5625     5625           
  Misses       2904     2904           
  Partials     1294     1294           
Flag Coverage Δ
integration 50.80% <ø> (ø)
unit 12.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dblock
Copy link
Member Author

dblock commented Apr 1, 2024

@Jakob3xD I tried releasing 3.1.0 following standard instructions, but it's not appearing in https://pkg.go.dev/github.com/opensearch-project/opensearch-go/v3.

I read https://go.dev/doc/modules/publishing and tried running GOPROXY=proxy.golang.org go list -m github.com/opensearch-project/opensearch-go@v3.1.0 but that fails with not found: ... invalid version: go.mod has post-v3 module path "github.com/opensearch-project/opensearch-go/v3" at revision v3.1.0.

What am I doing wrong?

... manually navigating to https://pkg.go.dev/github.com/opensearch-project/opensearch-go/v3@v3.1.0 gave me a "request" button which worked.

@dblock dblock merged commit a565c1d into opensearch-project:main Apr 1, 2024
58 checks passed
@dblock dblock deleted the 3.1.1-prepare branch April 1, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants