-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds the Fields
field containing the document fields to the SearchHit
struct
#508
Adds the Fields
field containing the document fields to the SearchHit
struct
#508
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #508 +/- ##
=======================================
Coverage 57.29% 57.29%
=======================================
Files 315 315
Lines 9823 9823
=======================================
Hits 5628 5628
Misses 2902 2902
Partials 1293 1293
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @thekogo for your contribution!
A few comments:
- Could we also add a test for the new field? https://github.com/opensearch-project/opensearch-go/blob/main/opensearchapi/api_search_test.go
- Please add a CHANGELOG entry.
Can you please signoff your commits? You can amend your commits using `git commit --amend -s" to sign them off. https://github.com/opensearch-project/opensearch-go/blob/main/CONTRIBUTING.md#developer-certificate-of-origin |
ab30c94
to
e95f8d3
Compare
Fields
field containing the document fields to the SearchHit
struct
Fields
field containing the document fields to the SearchHit
structfields
containing the document fields to the SearchHit
struct
fields
containing the document fields to the SearchHit
structFields
field containing the document fields to the SearchHit
struct
e95f8d3
to
6ebb1d8
Compare
…Hit` struct Signed-off-by: Ponlawat Suparat <thekogo@gmail.com>
6ebb1d8
to
7fa967d
Compare
Sorry I'm not sure why
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was able to get a clean run for prettify. Looks like some intermittent issue.
Description
Add fields
fields
inSearchHit
for support mapping response withfields
keyIssues Resolved
For support retrieve specific fields in the search response
Request
Response (add mapping for support this response)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.