-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing search_pipeline
field in opensearchapi.SearchParams
#532
Add missing search_pipeline
field in opensearchapi.SearchParams
#532
Conversation
9978925
to
9250b81
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #532 +/- ##
===========================================
+ Coverage 57.29% 67.93% +10.64%
===========================================
Files 315 376 +61
Lines 9823 8852 -971
===========================================
+ Hits 5628 6014 +386
+ Misses 2902 1556 -1346
+ Partials 1293 1282 -11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
9250b81
to
fcd2e3f
Compare
We do need tests for existing and new code, can you please add something simple that exercises params, please? |
5eb3e46
to
1c254cb
Compare
@dblock I have pushed up some simple tests, though it's proving a bit difficult to get it right as the I can either add make Would appreciate any suggestions 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @Jakob3xD has a good answer to your question?
Signed-off-by: Jack Hindmarch <jack.hindmarch@adarga.ai>
1c254cb
to
4aa53c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only thing missing is the build tag for testing.
Afterwards it is good to merge.
Co-authored-by: Jakob <jakob.hahn@hetzner.com> Signed-off-by: Jack Hindmarch <1750152+jackh-ncl@users.noreply.github.com>
Thank you 😃 |
Description
Added
search_pipeline
field in SearchParams struct.Note: I didn't add any tests as I can't see any others there for existing
SearchParam
fields.Context:
With the addition of hybrid search and search pipelines in Opensearch version
2.11
, a newsearch_pipeline
parameter exists on the_search
endpoint (docs here).Issues Resolved
This pull request supports the new search pipelines functionality by allowing users of the library to set the
search_pipeline
parameter via theSearchParams
struct.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.