Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove workflow test against gotip #604

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Conversation

Jakob3xD
Copy link
Collaborator

Description

In the past we tested the code against gotip to check if upcoming golang versions would break the application.
The tests only worked because of some sort of workaround as the setup-go ci job does not support tip, which stopped working. actions/setup-go#21

I don't think we require this test.

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com>
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.99%. Comparing base (06a6dc8) to head (aa764b0).
Report is 59 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #604       +/-   ##
===========================================
+ Coverage   57.29%   67.99%   +10.70%     
===========================================
  Files         315      376       +61     
  Lines        9823     8862      -961     
===========================================
+ Hits         5628     6026      +398     
+ Misses       2902     1555     -1347     
+ Partials     1293     1281       -12     
Flag Coverage Δ
integration 60.35% <ø> (+9.51%) ⬆️
unit 15.37% <ø> (+2.53%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 274 files with indirect coverage changes

@dblock dblock merged commit 2a80891 into opensearch-project:main Aug 26, 2024
57 checks passed
@Jakob3xD Jakob3xD deleted the jh-tip branch August 26, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants