Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugins/ism: Fix error notification types #613

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

Jakob3xD
Copy link
Collaborator

Description

  • Fix error notification types by making them pointers and adding omitempty
  • Add test for channel
  • Add missing struct for Channel field

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.99%. Comparing base (06a6dc8) to head (393ef12).
Report is 67 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #613       +/-   ##
===========================================
+ Coverage   57.29%   67.99%   +10.70%     
===========================================
  Files         315      376       +61     
  Lines        9823     8862      -961     
===========================================
+ Hits         5628     6026      +398     
+ Misses       2902     1555     -1347     
+ Partials     1293     1281       -12     
Flag Coverage Δ
integration 60.35% <ø> (+9.51%) ⬆️
unit 15.37% <ø> (+2.53%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
plugins/ism/api_policies.go 100.00% <ø> (ø)

... and 274 files with indirect coverage changes

Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com>
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, I started looking at ISM APIs in the API spec in opensearch-project/opensearch-api-specification#568.

@dblock dblock merged commit 64630c6 into opensearch-project:main Sep 11, 2024
54 checks passed
@Jakob3xD Jakob3xD deleted the jh-ism branch September 11, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants