Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PROPOSAL] Remove the strong dependency to jakarta.json-api #201

Closed
alexisgayte opened this issue Aug 2, 2022 · 4 comments · Fixed by #221
Closed

[PROPOSAL] Remove the strong dependency to jakarta.json-api #201

alexisgayte opened this issue Aug 2, 2022 · 4 comments · Fixed by #221
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@alexisgayte
Copy link

You have a strong dependency to jakarta.json-api 2.0.1 Which can conflict with other libs.
It doesn't seem to be necessary.

Thanks

@dblock
Copy link
Member

dblock commented Aug 2, 2022

Thanks @alexisgayte, want to PR a fix?

@dblock dblock added the bug Something isn't working label Aug 2, 2022
@alexisgayte
Copy link
Author

@dblock sorry, I don't have a fix.
But I noticed that you are doing a great job removing dependencies such as log4j.

Just for more context spring-boot conflict with it. it uses 1.1.6.

@dblock
Copy link
Member

dblock commented Aug 4, 2022

Thanks for the info @alexisgayte, but don't let me stop you from trying to fix it :)

@alexisgayte
Copy link
Author

Hi @VachaShah,
I don't think this PR will sort this issue out.

The main issue here is that using 2.x version bring retro incompatibility with other frameworks. As of now the current main lib in use for jakarta-json-api is 1.1.6.

Removing jakarta-json-api explicitly from your dependency tree, won't remove the implicit dependency declared with eclipse.parsson.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants