[Backport 2.x] Add batch_size param for text_embedding processor
#1312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Add batchSize parameter for text_embedding processor Signed-off-by: YeonghyeonKO <dk02315@gmail.com> * throw IllegalArgumentException when batchSize is not a positive integer Signed-off-by: YeonghyeonKO <dk02315@gmail.com> * test: add test cases for BatchSize param Signed-off-by: YeonghyeonKO <dk02315@gmail.com> * test: exception when batchSize is zero or negative integer Signed-off-by: YeonghyeonKO <dk02315@gmail.com> * refactor: use assertNotNull for readability & convention Signed-off-by: YeonghyeonKO <dk02315@gmail.com> * update CHANGELOG about #1298 PR Signed-off-by: YeonghyeonKO <dk02315@gmail.com> * apply code convention to keep the codes spotless Signed-off-by: YeonghyeonKO <dk02315@gmail.com> --------- Signed-off-by: YeonghyeonKO <dk02315@gmail.com> Signed-off-by: Thomas Farr <tsfarr@amazon.com> Co-authored-by: Thomas Farr <tsfarr@amazon.com> (cherry picked from commit 6c3e68f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
reta,
Bukhtawar,
dblock,
szczepanczykd,
madhusudhankonda,
saratvemulapalli,
VachaShah and
Xtansia
as code owners
Xtansia
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 6c3e68f from #1298.