Only add SPDX license to new files. #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
dblock
changed the title
VachaShah
approved these changes
Jul 12, 2022
saratvemulapalli
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel (dB.) Doubrovkine dblock@amazon.com
Description
In #177 we have contributors creating files that carry the SPDX license header, a copyright notice from Elastic and a modifications line. Only SPDX is required for new code. This PR removes it from checkstyle. We have to continue making sure we don't merge anything that removes any existing copyright notices when reviewing pull requests.
I'm still confirming that this is ok.I've confirmed this is ok and PRed opensearch-project/.github#76 to update guidance on what we'd like ideally. Note that it includes copyright in every header, which I am not doing as part of this PR, it's a nice to have.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.