Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: deprecate totalDataSetSize and totalDataSetSizeInBytes in S… #498

Merged
merged 2 commits into from
May 23, 2023
Merged

refactor: deprecate totalDataSetSize and totalDataSetSizeInBytes in S… #498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1d43c2
refactor: deprecate totalDataSetSize and totalDataSetSizeInBytes in S…
szczepanczykd May 23, 2023
1e39e5e
update CHANGELOG.md
szczepanczykd May 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,8 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
- Update maintainers, admins and documentation ([#248](https://github.com/opensearch-project/opensearch-java/pull/248))

### Deprecated
- Deprecate the totalDataSetSize and totalDataSetSizeInBytes fields in the StoreStats ([#498](https://github.com/opensearch-project/opensearch-java/pull/498))


### Removed
- Remove support for unsupported dynamic_templates in bulk ([#276](https://github.com/opensearch-project/opensearch-java/pull/276))
Expand Down
16 changes: 16 additions & 0 deletions java-client/src/main/java/org/opensearch/client/opensearch/_types/StoreStats.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,11 @@ public class StoreStats implements JsonpSerializable {

private final long reservedInBytes;

@Deprecated
@Nullable
private final String totalDataSetSize;

@Deprecated
@Nullable
private final Long totalDataSetSizeInBytes;

Expand Down Expand Up @@ -118,16 +120,22 @@ public final long reservedInBytes() {
}

/**
* @deprecated
* Not returned by server
* API name: {@code total_data_set_size}
*/
@Deprecated
@Nullable
public final String totalDataSetSize() {
return this.totalDataSetSize;
}

/**
* @deprecated
* Not returned by server
* API name: {@code total_data_set_size_in_bytes}
*/
@Deprecated
@Nullable
public final Long totalDataSetSizeInBytes() {
return this.totalDataSetSizeInBytes;
Expand Down Expand Up @@ -190,9 +198,11 @@ public static class Builder extends ObjectBuilderBase implements ObjectBuilder<S

private Long reservedInBytes;

@Deprecated
@Nullable
private String totalDataSetSize;

@Deprecated
@Nullable
private Long totalDataSetSizeInBytes;

Expand Down Expand Up @@ -229,16 +239,22 @@ public final Builder reservedInBytes(long value) {
}

/**
* @deprecated
* Not returned by server
* API name: {@code total_data_set_size}
*/
@Deprecated
public final Builder totalDataSetSize(@Nullable String value) {
this.totalDataSetSize = value;
return this;
}

/**
* @deprecated
* Not returned by server
* API name: {@code total_data_set_size_in_bytes}
*/
@Deprecated
public final Builder totalDataSetSizeInBytes(@Nullable Long value) {
this.totalDataSetSizeInBytes = value;
return this;
Expand Down