Fixes #283 #538
Merged
Fixes #283 #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urinud
requested review from
reta,
Bukhtawar,
dblock,
szczepanczykd,
madhusudhankonda,
saratvemulapalli and
VachaShah
as code owners
|
Thanks for the pull request @urinud , could you please add a few test cases to verify the change under |
|
Also this is a breaking change to existing users, isn't it? |
I don’t think is a breaking change as zero is not a valid value for the slices. Also this change maintains consistency with the equivalent feature in Elastic. |
dblock
requested changes
Jun 28, 2023
java-client/src/test/java/org/opensearch/client/opensearch/core/DeleteByQueryRequestTest.java
Outdated
Show resolved
Hide resolved
java-client/src/test/java/org/opensearch/client/opensearch/core/ReindexRequestTest.java
Outdated
Show resolved
Hide resolved
urinud
force-pushed
the
Fix-283
branch
3 times, most recently
from
0eeae4a
to
a477810
Compare
dblock
approved these changes
Jun 28, 2023
dblock
reviewed
Jun 28, 2023
java-client/src/test/java/org/opensearch/client/opensearch/core/DeleteByQueryRequestTest.java
Show resolved
Hide resolved
dblock
requested changes
Jun 28, 2023
Signed-off-by: Uriel Dan Nudelman <urinud@gmail.com>
Signed-off-by: Uriel Dan Nudelman <urinud@gmail.com>
dblock
approved these changes
Jun 30, 2023
|
Hello @reta and @VachaShah can you please help reviewing the PR? Is there anything else I should have added? |
reta
approved these changes
Jul 3, 2023
reta
pushed a commit
that referenced
this pull request
Jul 3, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the option to set slices=auto for UpdateByQueryRequest, DeleteByQueryRequest and ReindexRequest.
Using value 0 (zero) to express auto slicing.
This maintains consistency with elastic/elasticsearch#53068
Issues Resolved
Fixes #283
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.