Add indexing and search index settings #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds indexing and search settings to index settings. These settings allow configuring of slow logs for indexing and search, as well as setting search idle after. Search idle after duplicates the individual IndexSettings::searchIdleAfter property, but this pattern is already present e.g. IndexSettings::blocks and IndexSettings::blocksReadOnly, IndexSettings::blocksRead, etc. Signed-off-by: Russ Cam <russcam@canva.com>
russcam
requested review from
reta,
Bukhtawar,
dblock,
szczepanczykd,
madhusudhankonda,
saratvemulapalli and
VachaShah
as code owners
Signed-off-by: Russ Cam <russcam@canva.com>
russcam
force-pushed
the
russcam-add-slowlog-indexsettings
branch
from
6726aca
to
45d59a6
Compare
dblock
previously approved these changes
Oct 20, 2023
There was a problem hiding this comment.
This looks good to me! Do you think you could add some words to the user guide(s) in https://github.com/opensearch-project/opensearch-java/tree/main/guides and maybe a sample to https://github.com/opensearch-project/opensearch-java/tree/main/samples for these features?
reta
reviewed
Oct 20, 2023
java-client/src/main/java/org/opensearch/client/opensearch/indices/IndexSettingsIndexing.java
Show resolved
Hide resolved
Signed-off-by: Russ Cam <russcam@canva.com>
|
@dblock I've added a sample and docs |
|
Thank you @russcam! Can you apply |
Signed-off-by: Russ Cam <russcam@canva.com>
|
@VachaShah done! |
VachaShah
approved these changes
Oct 25, 2023
reta
approved these changes
Oct 25, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 25, 2023
* Add indexing and search index settings This commit adds indexing and search settings to index settings. These settings allow configuring of slow logs for indexing and search, as well as setting search idle after. Search idle after duplicates the individual IndexSettings::searchIdleAfter property, but this pattern is already present e.g. IndexSettings::blocks and IndexSettings::blocksReadOnly, IndexSettings::blocksRead, etc. Signed-off-by: Russ Cam <russcam@canva.com> * add changelog entry Signed-off-by: Russ Cam <russcam@canva.com> * Add documentation and sample Signed-off-by: Russ Cam <russcam@canva.com> * Update IndexTemplates Signed-off-by: Russ Cam <russcam@canva.com> --------- Signed-off-by: Russ Cam <russcam@canva.com> (cherry picked from commit 9408cc2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta
pushed a commit
that referenced
this pull request
Oct 25, 2023
* Add indexing and search index settings This commit adds indexing and search settings to index settings. These settings allow configuring of slow logs for indexing and search, as well as setting search idle after. Search idle after duplicates the individual IndexSettings::searchIdleAfter property, but this pattern is already present e.g. IndexSettings::blocks and IndexSettings::blocksReadOnly, IndexSettings::blocksRead, etc. * add changelog entry * Add documentation and sample * Update IndexTemplates --------- (cherry picked from commit 9408cc2) Signed-off-by: Russ Cam <russcam@canva.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta
pushed a commit
to reta/opensearch-java
that referenced
this pull request
Oct 27, 2023
* Add indexing and search index settings This commit adds indexing and search settings to index settings. These settings allow configuring of slow logs for indexing and search, as well as setting search idle after. Search idle after duplicates the individual IndexSettings::searchIdleAfter property, but this pattern is already present e.g. IndexSettings::blocks and IndexSettings::blocksReadOnly, IndexSettings::blocksRead, etc. Signed-off-by: Russ Cam <russcam@canva.com> * add changelog entry Signed-off-by: Russ Cam <russcam@canva.com> * Add documentation and sample Signed-off-by: Russ Cam <russcam@canva.com> * Update IndexTemplates Signed-off-by: Russ Cam <russcam@canva.com> --------- Signed-off-by: Russ Cam <russcam@canva.com> Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
reta
pushed a commit
to reta/opensearch-java
that referenced
this pull request
Oct 27, 2023
* Add indexing and search index settings This commit adds indexing and search settings to index settings. These settings allow configuring of slow logs for indexing and search, as well as setting search idle after. Search idle after duplicates the individual IndexSettings::searchIdleAfter property, but this pattern is already present e.g. IndexSettings::blocks and IndexSettings::blocksReadOnly, IndexSettings::blocksRead, etc. Signed-off-by: Russ Cam <russcam@canva.com> * add changelog entry Signed-off-by: Russ Cam <russcam@canva.com> * Add documentation and sample Signed-off-by: Russ Cam <russcam@canva.com> * Update IndexTemplates Signed-off-by: Russ Cam <russcam@canva.com> --------- Signed-off-by: Russ Cam <russcam@canva.com> Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds indexing and search settings to index settings. These settings allow configuring of slow logs for indexing and search, as well as setting search idle after.
Search idle after duplicates the individual
IndexSettings::searchIdleAfterproperty, but this pattern is already present e.g.IndexSettings::blocksandIndexSettings::blocksReadOnly,IndexSettings::blocksRead, etc.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.