Accept null in arrays #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 24, 2023 16:00
Signed-off-by: Karthik Subramanian <ksubramanian@scholastic.com>
Signed-off-by: Karthik Subramanian <ksubramanian@scholastic.com>
karthiks3000
requested review from
reta,
Bukhtawar,
dblock,
szczepanczykd,
madhusudhankonda,
saratvemulapalli and
VachaShah
as code owners
added 2 commits
October 24, 2023 16:05
Signed-off-by: Karthik Subramanian <ksubramanian@scholastic.com>
Signed-off-by: Karthik Subramanian <ksubramanian@scholastic.com>
VachaShah
approved these changes
Oct 24, 2023
dblock
approved these changes
Oct 24, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 27, 2023
* changes to allow nulls in arrays Signed-off-by: Karthik Subramanian <ksubramanian@scholastic.com> * changes to allow nulls in arrays Signed-off-by: Karthik Subramanian <ksubramanian@scholastic.com> * updated changelog with correct PR Signed-off-by: Karthik Subramanian <ksubramanian@scholastic.com> * SpotlessJavaCheck violations fixed Signed-off-by: Karthik Subramanian <ksubramanian@scholastic.com> --------- Signed-off-by: Karthik Subramanian <ksubramanian@scholastic.com> Co-authored-by: Karthik Subramanian <ksubramanian@scholastic.com> (cherry picked from commit de8c2a9) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta
pushed a commit
that referenced
this pull request
Oct 27, 2023
* changes to allow nulls in arrays * changes to allow nulls in arrays * updated changelog with correct PR * SpotlessJavaCheck violations fixed --------- (cherry picked from commit de8c2a9) Signed-off-by: Karthik Subramanian <ksubramanian@scholastic.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Karthik Subramanian <ksubramanian@scholastic.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is PR is based on elastic/elasticsearch-java#68 PR from the elasticsearch-java library. Reproducing it here since the library is licensed under Apache 2.0.
Issues Resolved
Closes #176
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.