Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wrapper to builder #806

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Add wrapper to builder #806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ This section is for maintaining a changelog for all breaking changes for the cli
### Added
- Document HTTP/2 support ([#330](https://github.com/opensearch-project/opensearch-java/pull/330))
- Expose HTTP status code through `ResponseException#status` ([#756](https://github.com/opensearch-project/opensearch-java/pull/756))
- Added missing WrapperQuery accessors and builder methods ([#806](https://github.com/opensearch-project/opensearch-java/pull/806))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I merged this too quickly. This changelog line should be added to the [Unreleased 2.x] section since this is to be released in 2.x. This way, the backport workflow also will not have merge conflicts.



### Dependencies

Expand Down
27 changes: 27 additions & 0 deletions java-client/src/main/java/org/opensearch/client/opensearch/_types/query_dsl/Query.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1153,6 +1153,23 @@ public WildcardQuery wildcard() {
return TaggedUnionUtils.get(this, Kind.Wildcard);
}

/**
* Is this variant instance of kind {@code wrapper}?
*/
public boolean isWrapper() {
return this._kind == Query.Kind.Wrapper;
}

/**
* Get the {@code wrapper} variant value.
*
* @throws IllegalStateException
* if the current variant is not of the {@code wrapper} kind.
*/
public WrapperQuery wrapper() {
return (WrapperQuery) TaggedUnionUtils.get(this, Query.Kind.Wrapper);
}

/**
* Is this variant instance of kind {@code type}?
*/
Expand Down Expand Up @@ -1743,6 +1760,16 @@ public ObjectBuilder<Query> wildcard(Function<WildcardQuery.Builder, ObjectBuild
return this.wildcard(fn.apply(new WildcardQuery.Builder()).build());
}

public ObjectBuilder<Query> wrapper(WrapperQuery v) {
this._kind = Query.Kind.Wrapper;
this._value = v;
return this;
}

public ObjectBuilder<Query> wrapper(Function<WrapperQuery.Builder, ObjectBuilder<WrapperQuery>> fn) {
return this.wrapper(fn.apply(new WrapperQuery.Builder()).build());
}

public ObjectBuilder<Query> type(TypeQuery v) {
this._kind = Kind.Type;
this._value = v;
Expand Down
Loading