Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update co.elastic to org.opensearch #88

Merged
merged 7 commits into from
Feb 3, 2022

Conversation

imRishN
Copy link
Member

@imRishN imRishN commented Feb 2, 2022

Description

This PR updates namespace co.elastic to org.opensearch and fixes checkstyle issues.

Issues Resolved

#12

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* Move folder co.elastic to org.opensearch
* Modify co.elastic to org.opensearch
* Organize imports
* Fix LineLength errors

Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
…ch.clients.opensearch

Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
@imRishN imRishN marked this pull request as ready for review February 2, 2022 14:00
mitalawachat and others added 3 commits February 2, 2022 20:09
…earch-project#8)

Unit Tests fix

Signed-off-by: Mital Awachat <mitalawachat@users.noreply.github.com>
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
Co-authored-by: Mital Awachat <awachatm@amazon.com>
Signed-off-by: Mital Awachat <mitalawachat@users.noreply.github.com>
Copy link
Member

@vamshin vamshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

java-client/build.gradle.kts Outdated Show resolved Hide resolved
java-client/build.gradle.kts Outdated Show resolved Hide resolved
java-client/build.gradle.kts Outdated Show resolved Hide resolved
docs/installation.asciidoc Outdated Show resolved Hide resolved
docs/installation.asciidoc Outdated Show resolved Hide resolved
@vamshin vamshin self-requested a review February 2, 2022 20:47
@reta
Copy link
Collaborator

reta commented Feb 2, 2022

@imRishN thanks for this change, I see 99% of the files in this pull request start with

// THIS CODE IS GENERATED. MANUAL EDITS WILL BE LOST.
//----------------------------------------------------

I am wondering, did you regenerate these files or changed them manually? Thank you.

@imRishN
Copy link
Member Author

imRishN commented Feb 3, 2022

@imRishN thanks for this change, I see 99% of the files in this pull request start with

// THIS CODE IS GENERATED. MANUAL EDITS WILL BE LOST.
//----------------------------------------------------

I am wondering, did you regenerate these files or changed them manually? Thank you.

I changed them manually. The above snippet has come from elasticsearch-java repo which will be removed in subsequent PRs. Thanks.

Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
@imRishN imRishN merged commit 58394be into opensearch-project:0.2.1 Feb 3, 2022
@imRishN imRishN deleted the 0.2.1 branch February 3, 2022 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants