Refactor BaseConnectionPool empty method #585
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, needs a test please. |
bandinib-amzn
force-pushed
the
baseconnectionpool-empty
branch
2 times, most recently
from
d79eb8b
to
79efb7c
Compare
Signed-off-by: Bandini Bhopi <bandinib@amazon.com>
bandinib-amzn
force-pushed
the
baseconnectionpool-empty
branch
from
79efb7c
to
3090248
Compare
bandinib-amzn
requested review from
ananzh,
kavilla,
seanneumann,
dblock,
VachaShah,
nhtruong,
harshavamsi and
timursaurus
as code owners
Added UT with no connection. |
dblock
reviewed
Aug 15, 2023
| @@ -18,6 +18,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) | |||
| - Bumps `eslint-config-prettier` from 8.8.0 to 9.0.0 | |||
| ### Changed | |||
| - Make handling of long numerals an option that is disabled by default ([#557](https://github.com/opensearch-project/opensearch-js/pull/557)) | |||
| - Refactor BaseConnectionPool empty method so that callback will always get called even when there is no connection ([#585](https://github.com/opensearch-project/opensearch-js/pull/585)) | |||
There was a problem hiding this comment.
I think this is really a bug fix, the callback should be called when there's no connections. So I would move this to fixes and say "Fix: ensure connection pool callback with no connections"
| pool.empty(); | ||
| t.equal(pool.size, 0); | ||
| t.end(); | ||
| }); |
There was a problem hiding this comment.
Can we add a test that ensures the callback is called, too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ConnectionPool.empty() never calls callback when there is no connection. Refactor empty method so that callback will get always called.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
Check List
yarn run lintdoesn't show any errorsBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.