[BUG] Deadlock prone code in HttpConnection.cs #689 #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Changed synchronous methods in HttpConnection.cs to use Task.Run/await to avoid deadlocks in accordance with: https://learn.microsoft.com/en-us/archive/blogs/jpsanders/asp-net-do-not-use-task-result-in-main-context
DavidPoulsenHGS
requested review from
anirudha,
dblock,
joshuali925,
Xtansia,
VachaShah,
MaxKsyunz and
Yury-Fridlyand
as code owners
joefeser
suggested changes
Aug 2, 2024
| @@ -120,7 +121,9 @@ public virtual TResponse Request<TResponse>(RequestData requestData) | |||
| if (responseMessage.Content != null) | |||
| { | |||
| receive = DiagnosticSource.Diagnose(DiagnosticSources.HttpConnection.ReceiveBody, requestData, statusCode); | |||
| responseStream = responseMessage.Content.ReadAsStreamAsync().GetAwaiter().GetResult(); | |||
| var task = Task.Run(() => responseMessage.Content.ReadAsStreamAsync()); | |||
There was a problem hiding this comment.
have you considered just changing it to responseMessage.Content.ReadAsStreamAsync().ConfigureAwait(false)?
| @@ -107,8 +107,9 @@ public virtual TResponse Request<TResponse>(RequestData requestData) | |||
|
|
|||
| if (requestData.ThreadPoolStats) | |||
| threadPoolStats = ThreadPoolStats.GetStats(); | |||
|
|
|||
| responseMessage = client.SendAsync(requestMessage, HttpCompletionOption.ResponseHeadersRead).GetAwaiter().GetResult(); | |||
| var task = Task.Run(() => client.SendAsync(requestMessage, HttpCompletionOption.ResponseHeadersRead)); | |||
There was a problem hiding this comment.
have you looked at using client.SendAsync(requestMessage, HttpCompletionOption.ResponseHeadersRead).ConfigureAwait(false)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes deadlock prone code in HttpConnection.cs. Changed synchronous methods in HttpConnection.cs to use Task.Run/Task.Wait to avoid deadlocks in accordance with: https://learn.microsoft.com/en-us/archive/blogs/jpsanders/asp-net-do-not-use-task-result-in-main-context
Issues Resolved
#689
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.