Update to Gradle 8.5 #58
Conversation
reta
force-pushed
the
update.gradle.8.5
branch
2 times, most recently
from
b8688ab to
4e88970
Compare
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
reta
force-pushed
the
update.gradle.8.5
branch
from
4e88970 to
43fa07d
Compare
reta
requested review from
sam-herman,
saratvemulapalli,
VachaShah,
kotwanikunal,
andrross and
anasalkouz
as code owners
| } | ||
| } | ||
| testRuntimeClasspath("org.slf4j:slf4j-api") { | ||
| implementation("com.oracle.oci.sdk:oci-java-sdk-common:${sdk_version}") |
There was a problem hiding this comment.
Those are not new dependencies, all of them were brought in transitively
There was a problem hiding this comment.
Hi @reta , curious why the preference to explicitly pin the versions as oppose to the above that will pull them transitively?
There was a problem hiding this comment.
@samuel-oci so the transitive dependencies are not pulled (the opensearch.plugin Gradle plugin alters that), the reason they were pulled before is because the use of xxxRuntimeClasspath / xxxCompileClasspath scopes - those are not allowed anymore (in Gradle)
There was a problem hiding this comment.
Got it, thanks @reta approved.
There was a problem hiding this comment.
@samuel-oci do you mind approving the workflow? seems like few checks need to be run, thank you
There was a problem hiding this comment.
Apologies, @samuel-oci may I ask you to approve one more time (fixed build issue), thank you
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Description
Update to Gradle 8.5
Issues Resolved
Part of opensearch-project/OpenSearch#10334
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.